benchmark: fix max-regressions detection in compare.js - #65587
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
RafaelGSS
approved these changes
Aug 27, 2026
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
panva
approved these changes
Aug 27, 2026
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/improve-benchmark-compare-max-regressions
branch
from
August 29, 2026 04:09
c62ff23 to
c0d3913
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/improve-benchmark-compare-max-regressions
branch
from
August 29, 2026 13:54
c0d3913 to
684d684
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the accuracy of the new
--max-regression Ndetection inbenchmark/compare.jsto eliminate false positive rate (using--oldand--newpointing to the same binary as the control).