tools: restore descending test timing order with --time - #65603
Open
Uziniii wants to merge 1 commit into
Open
Conversation
Signed-off-by: Uzini <43294422+Uziniii@users.noreply.github.com>
lpinca
previously approved these changes
Aug 29, 2026
Member
|
It seems that the original implementation was also sorting in ascending order Line 1756 in a16a0fe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65603 +/- ##
==========================================
- Coverage 90.12% 90.05% -0.07%
==========================================
Files 751 751
Lines 252638 254919 +2281
Branches 47551 48130 +579
==========================================
+ Hits 227689 229579 +1890
- Misses 16238 16520 +282
- Partials 8711 8820 +109 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--timeoption displays only the first 20 entries after sorting test durations. The current ascending sort therefore reports the fastest tests.Before
1fc4255221,CompareTime()sorted durations in descending order.That commit replaced the comparator with an ascending key-based sort while modernizing the Python code.
Sort durations in descending order to restore the historical behavior and report the tests that contribute most to the suite's execution time.
This also matches the output documented in: #27007
The change was verified with:
AI assistance was used to investigate the Git history and write this description as im not a native english. I reviewed and verified the change.