Skip to content

doc: clarify DEP0207 scope - #65618

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:DEP0207
Aug 30, 2026
Merged

doc: clarify DEP0207 scope#65618
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:DEP0207

Conversation

@aduh95

@aduh95 aduh95 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Refs: #63249

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 requested a review from pimterry August 28, 2026 14:00
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Aug 28, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 28, 2026
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Aug 28, 2026
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.07%. Comparing base (0544741) to head (a40ef9d).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65618      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         751      751              
  Lines      254921   254921              
  Branches    48129    48119      -10     
==========================================
- Hits       229627   229615      -12     
- Misses      16479    16489      +10     
- Partials     8815     8817       +2     

see 23 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✘  No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65618
βœ”  Done loading data for nodejs/node/pull/65618
----------------------------------- PR info ------------------------------------
Title      doc: clarify DEP0207 scope (#65618)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:DEP0207 -> nodejs:main
Labels     author ready, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    1
 - doc: clarify DEP0207 scope
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65618
Refs: https://github.com/nodejs/node/pull/63249
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65618
Refs: https://github.com/nodejs/node/pull/63249
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Fri, 28 Aug 2026 14:00:37 GMT
   βœ”  Approvals: 4
   βœ”  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/65618#pullrequestreview-5051810553
   βœ”  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65618#pullrequestreview-5054175316
   βœ”  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65618#pullrequestreview-5057320204
   βœ”  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65618#pullrequestreview-5058680973
   βœ”  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@aduh95
aduh95 merged commit bb5cffc into nodejs:main Aug 30, 2026
59 checks passed
@aduh95
aduh95 deleted the DEP0207 branch August 30, 2026 18:44
@aduh95

aduh95 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Landed in bb5cffc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants