Skip to content

test_runner: print failed coverage reports with dot runner - #65628

Closed
saitejabandaru-in wants to merge 1 commit into
nodejs:mainfrom
saitejabandaru-in:fix-60884-dot-reporter-coverage
Closed

test_runner: print failed coverage reports with dot runner#65628
saitejabandaru-in wants to merge 1 commit into
nodejs:mainfrom
saitejabandaru-in:fix-60884-dot-reporter-coverage

Conversation

@saitejabandaru-in

Copy link
Copy Markdown

Fixes #60884

When the coverage threshold is not met, the test runner emits a test:diagnostic event with level = "error". Previously, the dot reporter was suppressing this entirely, leading to silent failures on coverage if there were no standard test failures.
This change pushes a synthetic test failure on this condition to failedTests and increments the dot counter with an X, so it reports gracefully at the end.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 28, 2026
@MikeMcC399

MikeMcC399 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

You have opened a PR that claims to fix issue #60884 which is already closed because it is resolved through PR #61423.

Your PR branch is also 523 commits behind the main branch.

@MikeMcC399

Copy link
Copy Markdown
Contributor

#60884 was resolved through 2858f34 from #61423

This PR is therefore no longer necessary and is being closed.

It also fails linting.

@MikeMcC399 MikeMcC399 closed this Aug 29, 2026
@MikeMcC399 MikeMcC399 added invalid Issues and PRs that are invalid. and removed needs-ci PRs that need a full CI run. labels Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (0012a77) to head (6c6d74e).
⚠️ Report is 531 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/reporter/dot.js 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65628      +/-   ##
==========================================
- Coverage   90.14%   90.06%   -0.08%     
==========================================
  Files         746      751       +5     
  Lines      242771   254993   +12222     
  Branches    45741    48150    +2409     
==========================================
+ Hits       218850   229669   +10819     
- Misses      15426    16499    +1073     
- Partials     8495     8825     +330     
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/dot.js 67.14% <87.50%> (-32.86%) ⬇️

... and 296 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Issues and PRs that are invalid. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_runner: print failed coverage reports with dot runner

3 participants