test: fix link-local dgram scope assertion - #65629
Closed
panva wants to merge 1 commit into
Closed
Conversation
AIX can report lo0 as the scope ID for a datagram sent to a local interface. Validate that the received address includes a non-empty scope ID and verify that the address can be used to reply, instead of requiring the scope ID to match the destination interface. Refs: nodejs#46792 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Aug 28, 2026
panva
added
author ready
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65629 +/- ##
==========================================
- Coverage 90.07% 90.05% -0.03%
==========================================
Files 751 751
Lines 254986 254994 +8
Branches 48147 48156 +9
==========================================
- Hits 229681 229623 -58
- Misses 16492 16553 +61
- Partials 8813 8818 +5 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
Remaining CI failures to be resolved by #65636 |
panva
added a commit
that referenced
this pull request
Aug 29, 2026
AIX can report lo0 as the scope ID for a datagram sent to a local interface. Validate that the received address includes a non-empty scope ID and verify that the address can be used to reply, instead of requiring the scope ID to match the destination interface. Refs: #46792 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65629 Refs: #46792 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
|
Landed in 15b5b21 |
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
AIX can report lo0 as the scope ID for a datagram sent to a local interface. Validate that the received address includes a non-empty scope ID and verify that the address can be used to reply, instead of requiring the scope ID to match the destination interface. Refs: #46792 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65629 Refs: #46792 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the consistent failures on aix72-power9 by aligning the test with the actual contract rather than relying on infra removing network devices which make the test skip.
AIX can report lo0 as the scope ID for a datagram sent to a local interface. Validate that the received address includes a non-empty scope ID and verify that the address can be used to reply, instead of requiring the scope ID to match the destination interface.
Refs: #46792