test: update WPT for streams to 4832db4761 - #65638
Open
standard-Chan wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
Update the streams Web Platform Tests to upstream commit 4832db47614f5f48cc57374cbf5c1f70937fad48. Adjust the streams WPT status entries for owning-type tests that were renamed to tentative files upstream. Signed-off-by: Jeong SeokChan <starp321@naver.com>
standard-Chan
force-pushed
the
test-update-streams-wpt
branch
from
August 29, 2026 07:57
1a7ee9b to
43ab95b
Compare
panva
approved these changes
Aug 29, 2026
Member
|
Usually we'd do this with our WPT updater workflow but since this also needs an expectation update it's fine 👍 I checked the exact sha to match what's in the PR. |
panva
reviewed
Aug 29, 2026
panva
left a comment
Member
There was a problem hiding this comment.
Files: 144/152 ran, 138 passed, 8 skipped, 4 expected failures, 2 unexpected failures, 0 unexpected passes
Subtests: 2812 passed, 0 skipped, 14 expected failures, 2 unexpected failures, 0 unexpected passes
"readable-streams/from.any.html": {
"fail": {
"unexpected": [
"ReadableStream.from throws on invalid iterables; specifically a string"
]
}
},
"readable-streams/from.any.worker.html": {
"fail": {
"unexpected": [
"ReadableStream.from throws on invalid iterables; specifically a string"
]
}
},
Please acknowledge these failures and open an issue or if you feel like it a followup PR to fix them
Add the ReadableStream.from() string invalid iterable test to the streams WPT expected failures. Signed-off-by: Jeong SeokChan <starp321@naver.com>
Contributor
Author
|
Thanks for pointing this out. I've updated streams.json to mark these tests as expected failures. |
panva
approved these changes
Aug 29, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65638 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 754 754
Lines 255722 255722
Branches 48314 48320 +6
=======================================
+ Hits 230281 230298 +17
+ Misses 16555 16549 -6
+ Partials 8886 8875 -11 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Aug 29, 2026
jasnell
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the streams Web Platform Tests to upstream commit 4832db4761.
The streams WPT were last updated in nodejs/node#62864 in April 2026, so this brings the vendored tests up to a more recent upstream revision.
This also updates the streams WPT status entries for owning-type tests that were renamed upstream from
.any.jsto.tentative.any.js.Related upstream rename PR
Validation