Repository navigation
Qualify Cognee governance complement seams - #90
Merged
Merged
Conversation
nomed
commented
Aug 28, 2026
nomed
left a comment
Owner
Author
There was a problem hiding this comment.
PASS — READY TO MERGE. The preflight is narrow and falsifiable, pins the candidate revision, freezes the public auth + dataset ACL grant/revoke seams, and explicitly preserves the two critical limitations: dataset-level granularity and denied-search-as-empty semantics. No blocker found; this correctly authorizes the bounded executable gate without implying COMPLEMENT_PASS.
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts #89 under #87/#88 on pinned Cognee
690c0ec023719a2a277dc893cdecfec1ca8012cc.This PR freezes only the public seam contract before paying the cost of a bounded executable Cognee stack.
Evidence-backed candidate seam
The pin exposes public auth registration/login/API-key flows and a provider-native dataset ACL model. Public permission routes include explicit grant and revoke on a principal + dataset, with permissions
read,write,delete,share; the permission model includes User/Role/Tenant principals andsharegates grant/revoke.The preflight also freezes two limitations that must survive into the executable decision:
A green run means only
EXECUTABLE_CANDIDATE; it is not yetCOMPLEMENT_PASS.Next slice remains the normalized #89 gate: A owns M → B denied → explicit grant → fresh B reads → explicit revoke while A/B/M remain alive → fresh B denied → restart → enforcement persists.
Related: #63, #77, #87, #88, #89, #86.