Repository navigation
fix(deps): drop the unused puffin_http dependency - #30
Merged
Merged
Conversation
The library never calls puffin_http; profile-with-puffin only needs profiling's puffin scopes. The optional dependency still put puffin 0.16 and lz4_flex 0.10 into every dependent's lockfile, and lz4_flex before 0.11.6 can leak uninitialised memory when decompressing. The hello-portals example, which serves the profiler, moves to puffin_http 0.16.
nongio
force-pushed
the
fix/drop-puffin-http
branch
from
October 3, 2026 13:39
ddd0ea7 to
9c83cf6
Compare
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lay-rs never calls
puffin_http;profile-with-puffinonly needsprofiling's puffin scopes. The optional dependency still putpuffin_http 0.13→puffin 0.16→lz4_flex 0.10into every dependent'sCargo.lock, which Dependabot flags on Otto (lz4_flex < 0.11.6 can leak uninitialised memory on decompression).profile-with-puffin = ["profiling/profile-with-puffin"]puffin_http 0.16(samepuffin 0.19thatprofilinguses, so its server now sees the library's scopes)cargo check -p laye-rs --features profile-with-puffinandcargo check -p hello-portalspass. Otto needs a tag with this to clear the alert.