Repository navigation
syncv2: add support for DNS questions in NetworkFlowRule - #167
Conversation
|
The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe protobuf schema adds DNS-question data to network-flow events and DNS-question matching and response configuration to network-flow rules. It also updates tier descriptions to include DNS-question name matching. ChangesDNS question schema
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to No actionable issue established by the supplied evidence prevents this schema change from merging after normal checks. 🚥 Pre-merge checks | ✅ 1 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
f90f89e to
ecb9e9d
Compare
ecb9e9d to
96147f0
Compare
Part of SNT-25
Part of WS-25