Skip to content

syncv2: add support for DNS questions in NetworkFlowRule - #167

Merged
sharvilshah merged 2 commits into
mainfrom
sbs/dns-question-rules
Oct 6, 2026
Merged

sharvilshah merged 2 commits into
mainfrom
sbs/dns-question-rules

Conversation

@sharvilshah

Copy link
Copy Markdown
Contributor

Part of SNT-25
Part of WS-25

@sharvilshah
sharvilshah requested review from a team as code owners October 1, 2026 11:18
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed⏩ skipped✅ passedOct 6, 2026, 3:21 PM

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 769d8ca9-2dc2-471c-95fb-68a886a471e2
📥 Commits

Reviewing files that changed from the base of the PR and between ecb9e9d and 96147f0.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 169107aa-f83d-445a-945f-a96a7cc2d81e
📥 Commits

Reviewing files that changed from the base of the PR and between f90f89e and ecb9e9d.

📒 Files selected for processing (1)
  • syncv2/v2.proto

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The protobuf schema adds DNS-question data to network-flow events and DNS-question matching and response configuration to network-flow rules. It also updates tier descriptions to include DNS-question name matching.

Changes

DNS question schema

Layer / File(s) Summary
DNS rule matching and responses
syncv2/v2.proto
NetworkFlowRule.Remote adds exact-name and suffix DNS-question matchers. The comments define matcher constraints and action outcomes. NetworkFlowRule.Add adds DNSResponse configuration for denied DNS rules, with NXDOMAIN and NODATA kinds. Tier descriptions now include DNS-question name matching.
DNS question event fields
syncv2/v2.proto
NetworkFlowEvent adds DNSQuestion with qtype and an optional dns_question field. Comments describe the reported DNS decision event fields.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ecb9e

No actionable issue established by the supplied evidence prevents this schema change from merging after normal checks.

🚥 Pre-merge checks | ✅ 1 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description only names tracking items and does not explain the DNS-question changes. The tracking references relate to the objectives, but the description is too vague to assess on its own. Add a brief summary of the changes, such as the new DNS-question matchers and DNS response handling in syncv2.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of DNS-question support to NetworkFlowRule, which is the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

pmarkowsky
pmarkowsky previously approved these changes Oct 3, 2026

@pmarkowsky pmarkowsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sharvilshah
sharvilshah force-pushed the sbs/dns-question-rules branch from ecb9e9d to 96147f0 Compare October 6, 2026 15:20
@sharvilshah
sharvilshah merged commit c80dac2 into main Oct 6, 2026
4 checks passed
@sharvilshah
sharvilshah deleted the sbs/dns-question-rules branch October 6, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants