You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: efc67afd-83d5-4445-b46f-a555bd5a7420
📥 Commits
Reviewing files that changed from the base of the PR and between 2b48541 and 888836e.
📒 Files selected for processing: 1
telemetry/v1.proto
🚧 Files skipped from review as they are similar to previous changes: 1
telemetry/v1.proto
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
📝 Walkthrough
The telemetry schema adds DNSActivity records for per-process DNS questions, including decisions, outcomes, answers, and dropped-question counts. SantaMessage adds dns_activity as event field 36.
Changes: DNS activity telemetry
Layer / File(s)
Summary
Define and expose DNS activity telemetry/v1.proto
Adds DNS decision, tier, and outcome enums; answer and question records; per-process question lists with a dropped-question count; and SantaMessage.dns_activity at field 36.
No merge-blocking issue was identified in the DNS activity schema; it is ready for normal checks.
Pre-merge checks: 2
Check name
Status
Explanation
Description check
The description accurately states that the pull request adds DNSActivity telemetry and leaves NetworkActivity unchanged.
Title check
The title clearly and concisely identifies the main change: adding DNSActivity telemetry.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Buf (1.73.0)
telemetry/v1.proto
fatal: unable to access 'https://github.com/northpolesec/protos.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch 5c0cf6feba3b21b4a4e519c30e8c36fc97d609e8 from promisor remote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DNSActivityin telemetry.NetworkActivityremains unchanged