Skip to content

telemetry: add DNSActivity - #173

Merged
sharvilshah merged 4 commits into
mainfrom
sbs/dns-telemetry
Oct 16, 2026
Merged

sharvilshah merged 4 commits into
mainfrom
sbs/dns-telemetry

Conversation

@sharvilshah

@sharvilshah sharvilshah commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Add DNSActivity in telemetry. NetworkActivity remains unchanged

@sharvilshah
sharvilshah requested a review from mlw October 14, 2026 22:48
@sharvilshah
sharvilshah requested review from a team as code owners October 14, 2026 22:48
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed⏩ skipped✅ passedOct 16, 2026, 5:36 PM

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: efc67afd-83d5-4445-b46f-a555bd5a7420
📥 Commits

Reviewing files that changed from the base of the PR and between 2b48541 and 888836e.

📒 Files selected for processing: 1
  • telemetry/v1.proto
🚧 Files skipped from review as they are similar to previous changes: 1
  • telemetry/v1.proto

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The telemetry schema adds DNSActivity records for per-process DNS questions, including decisions, outcomes, answers, and dropped-question counts. SantaMessage adds dns_activity as event field 36.

Changes: DNS activity telemetry

Layer / File(s) Summary
Define and expose DNS activity
telemetry/v1.proto
Adds DNS decision, tier, and outcome enums; answer and question records; per-process question lists with a dropped-question count; and SantaMessage.dns_activity at field 36.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 88883

No merge-blocking issue was identified in the DNS activity schema; it is ready for normal checks.

Pre-merge checks: Passed 2
Check name Status Explanation
Description check Passed The description accurately states that the pull request adds DNSActivity telemetry and leaves NetworkActivity unchanged.
Title check Passed The title clearly and concisely identifies the main change: adding DNSActivity telemetry.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Buf (1.73.0)
telemetry/v1.proto

fatal: unable to access 'https://github.com/northpolesec/protos.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch 5c0cf6feba3b21b4a4e519c30e8c36fc97d609e8 from promisor remote

CODERABBIT_BUF_COMPATIBILITY_PHASE=materialize-base

Comment @coderabbitai help to get the list of available commands.

@sharvilshah sharvilshah changed the title telemetry: add DNS questions to NetworkActivity telemetry: add DNSActivity Oct 15, 2026
@sharvilshah
sharvilshah merged commit 331ac87 into main Oct 16, 2026
4 checks passed
@sharvilshah
sharvilshah deleted the sbs/dns-telemetry branch October 16, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants