Skip to content

add disable_executable_integrity_recheck - #174

Merged
tburgin merged 1 commit into
mainfrom
bur/sync-disable-integrity-recheck
Oct 19, 2026
Merged

tburgin merged 1 commit into
mainfrom
bur/sync-disable-integrity-recheck

Conversation

@tburgin

@tburgin tburgin commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tburgin
tburgin requested review from a team as code owners October 19, 2026 20:37
@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed⏩ skipped✅ passedOct 19, 2026, 8:37 PM

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 48a7a742-6694-4987-9ce1-8515b8586313
📥 Commits

Reviewing files that changed from the base of the PR and between 331ac87 and 4bc5afa.

📒 Files selected for processing: 2
  • sync/v1.proto
  • syncv2/v2.proto

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The v1 schema reserves field 43 in PreflightResponse. The v2 schema adds the optional disable_executable_integrity_recheck field at field 43. Both schemas advance the next-ID comment to 44.

Changes: PreflightResponse field allocation

Layer / File(s) Summary
Define field 43
sync/v1.proto, syncv2/v2.proto
The v1 schema reserves field 43. The v2 schema adds optional boolean field disable_executable_integrity_recheck at field 43. Both next-ID comments advance to 44.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 4bc5a

The reviewed change adds the optional setting to the v2 response schema, with no concrete compatibility failure established. No actionable issue in this change blocks merging.

Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The pull request has no description, so it does not provide meaningful context about the changeset. Add a brief description that explains the new setting and its effect on executable integrity rechecks.
Passed Passed checks: 1 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding disable_executable_integrity_recheck.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tburgin
tburgin enabled auto-merge (squash) October 19, 2026 20:43
@tburgin
tburgin merged commit 11ba779 into main Oct 19, 2026
4 checks passed
@tburgin
tburgin deleted the bur/sync-disable-integrity-recheck branch October 19, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants