Repository navigation
Moved golangci-lint out of go.mod and rejected answers missing their values - #4
Merged
Merged
Conversation
A go.mod tool's requirements become every importer's, so depending on this SDK pulled golangci-lint's whole dependency graph into the importer's module graph and raised its versions (Workshop picked up about 100 module bumps). The Makefile now runs a pinned golangci-lint with go run, as it already does for actionlint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
encoding/json read an absent noul as 0, which means "no", so a malformed response looked like a confident answer. Noul, choice and score answers now fail to decode when a value they carry is missing or null, in both Result.Answers and DecodeAnswers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Vpr99
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of WS-1891
Two fixes found while switching Workshop's TypeSafe decisions backend to this SDK.
go.mod. As atool, its requirements became every importer's: adding this SDK to Workshop raised about 100 of its module versions, including golangci-lint itself (2.6 to 2.15). The Makefile now runs a pinned golangci-lint withgo run, as it already does for actionlint, andgo.modrequires onlyshoenig/test.noulas 0, which means "no", so a malformed response looked like a confident answer; Workshop'sclassify()would have allowed the binary. Noul, choice and score answers now return an error when a value they carry (noul;choice,confidence,probabilities;score,confidence,probabilities) is missing or null, in bothResult.AnswersandDecodeAnswers. Responses in the API docs' shape decode as before.make cipasses (lint, vet, tests with-race).🤖 Generated with Claude Code v2.1.306 (model: Opus 5.5 / claude-opus-5-5)