Repository navigation
feat(footer): support progressive enhancement and server consumers - #185
Merged
Merged
Conversation
AlonaDushyn
previously approved these changes
Sep 28, 2026
AlonaDushyn
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer newsletter submission currently requires a client callback, has no native endpoint or named email field, and can lose text entered before hydration. Add an HTML form baseline so applications can offer newsletter signup without JavaScript and use Footer directly from Next.js server pages and layouts.
newsletterAction,newsletterMethod(POST by default) andnewsletterInputName(emailby default). KeeponNewsletterSubmitas an optional client enhancement. The application owns the endpoint and subscription response.This PR targets main independently and contains no Header or Carousel implementation changes.
Validation on this branch:
npm run test:packaging, using the explicitly reported dependency exception below. No date cutoff is needed.Consumer dependency exception: Aksel icons 8.17.1, published on 2026-09-25, omits compiled icon modules. Fresh consumer test apps apply a root npm override with the replacement range
^8.16.1 <8.17.1 || ^8.17.2, excluding the broken release while permitting compatible future fixes. The README documents the same workaround for affected consuming applications, including applications that depend on the icons directly. Test output reports the exception. Library dependency constraints and lockfiles are unchanged; root overrides do not propagate from a library to its consumers. This works around the upstream defect rather than claiming unrestricted installation succeeds.The first Linux visual run passed 28/30 screenshots. The two Footer differences were reviewed: the unconfigured newsletter form is disabled and the placeholder unsubscribe link is plain text. Updated only those light/dark baselines using the Linux CI screenshots. CI checks all 30 screenshots against the updated baselines. Full manual screen-reader testing remains outstanding. Actual designportal and rodekors.no applications were not tested. Existing logo-policy documentation and guide-terminology conflicts are unchanged.