Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bee api issues/PROJECT-1/attachments/123 > image.pngnow writes the attachment bytes unchanged. Previously, an HTTP 200 image response failed with a JSON parsing error and left the output empty.--silent, omit output for empty responses, and report a clear error when--jsonis requested for a non-JSON response.Closes #178
Test plan
SyntaxError: ... is not valid JSON. After the fix,vp testpasses 804 tests across 118 files, including all 37 API-command tests.vp check,vp lint --max-warnings 0, andvp run --filter @nulab/bee generate:skill:checkpass.vp run -r buildbuilds the CLI and all 105 docs pages, with valid internal links.--silent, the non-JSON--jsonerror, and HTTP 204/403 handling work.Live Backlog attachment retrieval was not tested because no target issue was supplied. Network verification used a local fixture server and dummy API-key authentication.