Skip to content

Update: Redesign hold mouse status figure and add mouse options - #248

Merged
nutti merged 3 commits into
nutti:masterfrom
PhysicalAddons:feature/mouse-figure-redesign
Oct 16, 2026
Merged

nutti merged 3 commits into
nutti:masterfrom
PhysicalAddons:feature/mouse-figure-redesign

Conversation

@karlisup

Copy link
Copy Markdown
Contributor

Purpose of the pull request

Feature request

Description about the pull request

Redesigned the mouse figure shown for the hold mouse status: a single rounded
body with a scroll wheel. The previous figure is still available via the new
Mouse Style option.

Mouse Style

New options under Color:

  • Mouse Style: Original / Updated
  • Active Color: fill color of a pressed mouse button
  • Mouse Background: separate background color for the mouse, with alpha

Active Color

Mouse Background

Docs and changelog are updated.

Additional comments [Optional]

The new style is the default. Happy to switch the default to Original if you
prefer.

Draw the default mouse as a single rounded body with a scroll wheel.
The pressed button fill wraps around the wheel so the wheel stays
visible without a background.

New options (shown under Color when the hold mouse status is drawn):

* Mouse Style: Original / Updated (default: Updated)
* Active Color: fill color of a pressed mouse button
* Mouse Background: fill the mouse body with its own RGBA color

Also ignore __pycache__ directories.

@nutti nutti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @karlisup .
This will be a great feature addition.
Can you check my comments?

Comment thread CHANGELOG.md
Comment thread docs/tutorial.md Outdated
Comment thread src/screencast_keys/ops.py Outdated
Comment thread src/screencast_keys/ops.py Outdated
@nutti nutti added the enhancement New feature or request label Oct 15, 2026
@nutti nutti added this to the Version 4.3.0 milestone Oct 15, 2026
karlisup and others added 2 commits October 15, 2026 23:31
Update version naming convention.

Co-authored-by: nutti <nutti.metro@gmail.com>
* Do not modify CHANGELOG.md
* Rename mouse styles to v1 / v2
* Use if-elif-else for the style dispatch and raise on unknown style
@karlisup

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I've addressed all comments.
Let me know if anything else needs changing.

@nutti
nutti merged commit 6170995 into nutti:master Oct 16, 2026
26 checks passed
@nutti

nutti commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Thank you @karlisup for your contribution!
This is very nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants