Repository navigation
fix(debugger): listen for flutter.appStarted from the debug adapter - #564
Merged
Merged
Conversation
The adapter forwards `flutter run --machine`'s `app.started` as `flutter.appStarted`, so the `app.started` listener never ran: `FlutterToolsAppStarted` was not emitted under the debugger and the pre-start log buffer kept every line of the session. Fixes #563
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter.appStarted, the name Flutter's debug adapter forwardsapp.startedunder. Under the debugger,FlutterToolsAppStartedwas never emitted, and the pre-start log buffer kept growing for the whole session and was scanned for device errors on exit.flutter.appStarted→terminated.Fixes #563