Skip to content

test: stabilize memoize weak-ref GC spec on nvim v0.11.4 - #1184

Merged
kristijanhusak merged 2 commits into
masterfrom
copilot/fix-github-actions-job-failure
Sep 18, 2026
Merged

kristijanhusak merged 2 commits into
masterfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR addresses the failing GitHub Actions job tests (ubuntu-latest, v0.11.4) caused by a flaky weak-reference GC assertion in memoize_spec.lua. The test now isolates memoize behavior from parser/tree lifetime variance and tolerates delayed collection on v0.11.4.

Related Issues

Related #

Changes

  • Isolate parser/tree references in the weak-ref fixture
    • Clear both parser and parsed root before releasing the file reference.
  • Stabilize GC-sensitive assertion
    • Replace single-pass GC with bounded repeated collection (up to 10 rounds) before asserting weak ref release.
  • Scope
    • Test-only change in tests/plenary/utils/memoize_spec.lua; no runtime behavior changes.
file.parser = nil
file.root = nil

for _ = 1, 10 do
  if weak.file == nil then
    break
  end
  collect()
end

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

…ilot Coding Agent)

Co-authored-by: kristijanhusak <1782860+kristijanhusak@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job tests (ubuntu-latest, v0.11.4) test: stabilize memoize weak-ref GC spec on nvim v0.11.4 Sep 18, 2026
@kristijanhusak
kristijanhusak marked this pull request as ready for review September 18, 2026 21:31
@kristijanhusak
kristijanhusak merged commit e779d63 into master Sep 18, 2026
17 checks passed
@kristijanhusak
kristijanhusak deleted the copilot/fix-github-actions-job-failure branch September 18, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants