Skip to content

feat(aivision): add skill spans endpoint with span-backed aggregation - #10

Merged
webup merged 2 commits into
mainfrom
feat/agent-framework-langfuse-and-nemo
Oct 21, 2026
Merged

webup merged 2 commits into
mainfrom
feat/agent-framework-langfuse-and-nemo

Conversation

@sc-source

@sc-source sc-source commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem and impact

Add authenticated GET /api/v1/ai-vision/skill/spans to recall paginated candidate Skill spans for AI Vision #92. Recall includes native agentic.tool.type=skill, native agentic.skill.name, and argument payloads mentioning SKILL.md; the Python semantic layer rejudges candidates before counting them. Existing agent/tenant filters apply.

The review fix adds native-name recall (otherwise AICoder-style records without a path are missed) and orders timestamp ties by trace ID and span ID for stable pagination.

Validation

Current head: c49b2437d0f401f0ee60b73429bfa307dbecc600. Local real OceanBase-compatible SQL integration used an isolated cloned traces table and exercised the production handler: native-name-only recall plus 501 tied-timestamp candidates across three pages without duplicate/missing identities. The aivision Go module tests and Linux arm64 binary build passed. The same candidate binary served the real Pi/Baidu telemetry acceptance for AI Vision SigNoz#92. The three-Skill round reconciled 66 original spans in 12 traces through both Native/dashboard and SpaceKey APIs; candidate recall returned the exact 12 candidate identities, and the Python layer counted 9 calls (three per Skill). Provider/SSE usage and all original span IDs, parents and precise nanosecond timestamps matched. The candidate count is deliberately distinct from the final call count.

Hosted query-regression passed gofmt and go test -p 2 -count=1 ./pkg/modules/aivision. Hosted CI did not configure a real OceanBase DSN; real SQL evidence is the separate local run. The integration test skips unless SIGNOZ_TEST_OCEANBASE_DSN is supplied and cleans up its uniquely named test table.

Screenshots and interaction

No direct UI change. Source-span navigation and the Skill overview were checked through the compatible frontend in AI Vision SigNoz#92; screenshots accompany its documentation PR.

Compatibility and unverified scope

Deploy this query support together with AI Vision SigNoz#92. Candidate results are intentionally broad and are not final Skill invocation counts. Other architectures, a published image and production deployment were not verified. The stable ordering prevents ambiguous tie ordering; no production data-loss incident is claimed.

Add /skill/spans route, SkillSpans handler, skillSpanPredicateSQL predicate and listSkillSpans storage query to recall candidate skill spans for the Python-side skill scan.
@github-actions github-actions Bot added the enhancement New feature or request label Oct 21, 2026
@sc-source

Copy link
Copy Markdown
Collaborator Author

@webup

@webup webup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Codex assistance at this commit. Native-name recall and stable pagination match AI Vision SigNoz#92; hosted query-regression passed, and the separate local SQL/integration evidence covers the actual compatible stack. Hosted CI did not use a real OceanBase DSN.

@webup
webup merged commit d560a6a into main Oct 21, 2026
3 checks passed
@webup
webup deleted the feat/agent-framework-langfuse-and-nemo branch October 21, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants