Repository navigation
fix: translate parent_as/1 references in correlated subqueries - #136
Open
l-vincent-l wants to merge 1 commit into
Open
l-vincent-l wants to merge 1 commit into
l-vincent-l wants to merge 1 commit into
Conversation
The parent_as/1 field references that correlate a subquery to its parent query had no expr/3 clause and fell through to the catch-all, which rendered them as a bare `?`: the next bound parameter stood in for the field, silently changing the query. They are now resolved to the source of the named parent query, as in ecto_sqlite3. The parent query was already recorded under @parent_as by subqueries and CTEs, but never read.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parent_as/1field references, used to correlate a subquery to its parent query, have noexpr/3clause inEcto.Adapters.LibSql.Connectionand fall through to the catch-all, which renders them as a bare?:The next bound parameter then stands in for the field, silently changing the query.
Fix
Resolve parent_as(:name).field to the source of the named parent query, as ecto_sqlite3 does. The parent query was already recorded under @parent_as by subqueries and CTEs, but never read.
Tests
Added to test/in_expression_comprehensive_test.exs, reusing its test_items / archived_items tables: an IN subquery correlated to the parent query. It fails on main. mix test --exclude turso_remote: all passing. No Rust changes.