Repository navigation
Update interface versions for 12.1.7 - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AutoSetup.toc: Retail## Interfacegoes from120105to120105, 120107, so the addon loads as up to date on the 12.1.7 PTR as well as on live 12.1.5. Forever stays at16001(1.60.1, no new patch).Sources:
wow.py builds(live 12.1.5.70575, PTR 12.1.7.70493, Forever 1.60.1.70630) and the wiki's TOC format page (Standard 120105, Standard Test 120107, Forever 16001).API check
No code change needed. Checked the wiki's Patch 12.1.7/API changes and diffed live against PTR in Blizzard's UI source:
C_EditMode,C_AddOns,C_UI,C_Timercall and every event the addon registers is still there.Enum.AddOnEnableStatemoved toAddOnConstantsDocumentation; the addon comparesGetAddOnEnableState(...) > 0, so nothing changes.[Game]/[Family]variables don't touch AutoSetup.OptionsSliderTemplate(scale slider) is still only inDeprecatedTemplates.xml, as on live and Forever. Not changed here.For the reviewer: controller support on Retail
12.1.7 brings Forever's controller interface to Retail:
C_InputInterfaceStyle, theInputDeviceInterfaceStyleCVar and Edit Mode's per-layoutinterfaceStyleare now in Mainline's source, withGamepad.luaandInputUtil.luaidentical to Forever's.AutoSetup.hasControllerInterfacechecks onlyC_InputInterfaceStyle ~= nil, so the native controller checkbox will show on Retail 12.1.7. Blizzard registers its own Controller page only when the CVar exists (InputUtil.IsGamepadUISupported()).This PR doesn't change that. Still open: whether to also gate on the CVar, and updating the README's "WoW Forever only" wording, the comment at
AutoSetup.lua:21anddocs/TESTING.md13.3.Checks
luacheck .: 0 warnings / 0 errorsluac -p AutoSetup.lua FrameXML/*.lua: OK/reloadwithout errors,docs/TESTING.mditems 4-6 (layout switching, Edit Mode), 13 (options panel, controller checkbox) and 14 (reload popup).