Repository navigation
Say so when the game blocks setting controller support - #22
Merged
Merged
Conversation
SetCVar on InputDeviceInterfaceStyle can be blocked at the initial evaluation too (ADDON_ACTION_BLOCKED), and the popup still said it was just set. Read the CVar back and, when it didn't take, say the game blocked it and offer a reload or the Options page instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ApplyControllerSupportreadsInputDeviceInterfaceStyleback afterSetCVar.controllerSupportChangedThisSessionis now set only when the write took.Setting InputDeviceInterfaceStyle was blocked.docs/TESTING.mdsection 9 has a step for this.Why
The CVar is protected, and the initial evaluation after login can be blocked too (
ADDON_ACTION_BLOCKED, reason unknown, not every time). The popup still said the setting was just changed, and that a reload would finish it.For the reviewer
IsInputModeUnsettledstill sees the CVar mismatch.GetCVarreturns the new value right afterSetCVarfor this CVar. If it lagged, a successful set would show as blocked. That needs the new test step on Forever; it hasn't been tested in game yet.luacheckandluac -ppass.