Skip to content

Say so when the game blocks setting controller support - #22

Merged
ollidiemaus merged 1 commit into
mainfrom
fix/controller-support-blocked
Nov 6, 2026
Merged

ollidiemaus merged 1 commit into
mainfrom
fix/controller-support-blocked

Conversation

@ollidiemaus

Copy link
Copy Markdown
Owner

What changed

  • ApplyControllerSupport reads InputDeviceInterfaceStyle back after SetCVar. controllerSupportChangedThisSession is now set only when the write took.
  • When it didn't take, the popup says the game blocked it and to reload to try again or change it in Options > Controller. The debug log shows Setting InputDeviceInterfaceStyle was blocked.
  • docs/TESTING.md section 9 has a step for this.

Why

The CVar is protected, and the initial evaluation after login can be blocked too (ADDON_ACTION_BLOCKED, reason unknown, not every time). The popup still said the setting was just changed, and that a reload would finish it.

For the reviewer

  • Edit Mode stays left alone in the blocked case: IsInputModeUnsettled still sees the CVar mismatch.
  • The fix assumes GetCVar returns the new value right after SetCVar for this CVar. If it lagged, a successful set would show as blocked. That needs the new test step on Forever; it hasn't been tested in game yet.

luacheck and luac -p pass.

SetCVar on InputDeviceInterfaceStyle can be blocked at the initial
evaluation too (ADDON_ACTION_BLOCKED), and the popup still said it was
just set. Read the CVar back and, when it didn't take, say the game
blocked it and offer a reload or the Options page instead.
@ollidiemaus
ollidiemaus merged commit 7cad12d into main Nov 6, 2026
1 check passed
@ollidiemaus
ollidiemaus deleted the fix/controller-support-blocked branch November 6, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant