Skip to content

Fix the findings of the addon standards audit - #23

Merged
ollidiemaus merged 1 commit into
mainfrom
fix/controller-support-blocked
Nov 6, 2026
Merged

ollidiemaus merged 1 commit into
mainfrom
fix/controller-support-blocked

Conversation

@ollidiemaus

Copy link
Copy Markdown
Owner

What changed

Fixes from a full check of the addon against the WoW addon coding standards.

Bugs

  • UI scale: a new Set UI scale checkbox. Unticked leaves the scale alone; before, every save stored the slider value, clamped to 0.65 at the low end. Existing profiles have a scale saved, so they show as ticked.
  • Profile list: the scroll area grows with the list, so profiles past about the 7th can be reached.
  • Newer saved data (D4): profiles from a newer AutoSetup apply from a copy, so nothing is written into that file. Chat says changes won't be saved.
  • Partly enabled addons: an addon enabled on only some characters no longer counts as enabled. Enabling one switches it on for all characters.
  • Addon changes: saved at once with C_AddOns.SaveAddOns(), so cancelling the game's AddOn list can't undo them.
  • Layout popup: closes with the settings.
  • Controller interface: a change in the game's options is picked up through INPUT_DEVICE_INTERFACE_TRANSITION, which is registered only where the client knows it.

Cost

  • PLAYER_TARGET_CHANGED and PLAYER_SOFT_ENEMY_CHANGED stay off during combat, and combat end still checks the target.
  • Cleaned layout names are cached until the next full evaluation. A missing layout retries only while the layouts are still loading.

Cleanup

  • Removed the unused isForever and the popup's direct reload fallback.
  • ExecuteReload tries C_UI.Reload first.
  • The reload popup can be dragged.
  • Removed the unused slider font string.
  • The feature log reports a failed set.
  • The layout picker lists presets, except those for the other interface.
  • Removed docs/TESTING.md.

For the reviewer

  • luacheck, luac -p and XML parsing pass. Nothing has been run in game.
  • The partly enabled addon and SaveAddOns fixes come from reading Blizzard's source. If the "Reload required" popup comes back on every login, look at IsInDesiredState first.
  • The controller listener assumes the interface switches without a reload. An older comment in ApplyControllerSupport says a reload is needed after our own SetCVar, so this still needs settling in game.
  • Row creation in the options panel is unchanged on purpose: Blizzard's CreateFrame hook is the only refresh of an open panel, so the controller cursor needs it to reach new rows.

Saving a profile no longer changes the UI scale unless asked, every
profile in the list can be reached, and an older AutoSetup no longer
writes into a newer saved file. Addon changes are saved at once, addons
enabled on only some characters count as not enabled, and target events
stay off during combat. A controller interface change in the game's
options is picked up without a reload.

Also remove leftovers the audit found, and drop docs/TESTING.md: testing
now happens while playing.
@ollidiemaus
ollidiemaus merged commit 89e8d73 into main Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant