Repository navigation
Fix the findings of the addon standards audit - #23
Merged
Merged
Conversation
Saving a profile no longer changes the UI scale unless asked, every profile in the list can be reached, and an older AutoSetup no longer writes into a newer saved file. Addon changes are saved at once, addons enabled on only some characters count as not enabled, and target events stay off during combat. A controller interface change in the game's options is picked up without a reload. Also remove leftovers the audit found, and drop docs/TESTING.md: testing now happens while playing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes from a full check of the addon against the WoW addon coding standards.
Bugs
C_AddOns.SaveAddOns(), so cancelling the game's AddOn list can't undo them.INPUT_DEVICE_INTERFACE_TRANSITION, which is registered only where the client knows it.Cost
PLAYER_TARGET_CHANGEDandPLAYER_SOFT_ENEMY_CHANGEDstay off during combat, and combat end still checks the target.Cleanup
isForeverand the popup's direct reload fallback.ExecuteReloadtriesC_UI.Reloadfirst.docs/TESTING.md.For the reviewer
luacheck,luac -pand XML parsing pass. Nothing has been run in game.SaveAddOnsfixes come from reading Blizzard's source. If the "Reload required" popup comes back on every login, look atIsInDesiredStatefirst.ApplyControllerSupportsays a reload is needed after our ownSetCVar, so this still needs settling in game.CreateFramehook is the only refresh of an open panel, so the controller cursor needs it to reach new rows.