Repository navigation
Reload by itself after the controller support switch; validate the resolution field - #25
Merged
Merged
Conversation
…solution field Controller support is still set at PLAYER_LOGIN, in both directions. The game logs ADDON_ACTION_BLOCKED for that SetCVar (taint.log: the addon's own call, nothing tainted before it), but the value changes and the switch works after a reload, so the call stays. When it took, the initial evaluation now reloads the UI itself instead of asking for a second reload: not in combat, and not in the session right after such a reload (AutoSetupDB.reloadedForController), so a switch that doesn't survive the reload can't loop. Those cases keep the popup. From the addon standards audit: - CVar writes go through C_CVar.SetCVar, not the game's Lua wrapper. - Saving a profile strips whitespace from the resolution, lowercases the x and rejects anything that isn't WIDTHxHEIGHT; such a profile never matched. - Drop the InterfaceOptions fallbacks and the guards around helpers the core file always defines; both shipped flavors have Settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Controller support (WoW Forever)
PLAYER_LOGIN, in both directions. When it took, the initial evaluation now reloads the UI by itself instead of showing "Reload once more to finish applying it".AutoSetupDB.reloadedForController, which the next session clears; if the switch doesn't survive the reload, the popup appears instead of a reload loop. Saved data from a newer AutoSetup or unreadable data can't carry the mark, so those sessions keep the popup too.C_CVar.SetCVarinstead of the game's LuaSetCVarwrapper.Options panel
xand rejects anything that isn'tWIDTHxHEIGHT. Before,1920x1080or1920X1080saved a profile that never matched.InterfaceOptionsfallbacks and the guards around helpers the core file always defines; both shipped flavors haveSettings..luacheckrcloses the threeInterfaceOptionsglobals.Why
An audit against the addon standards found BugGrabber logging
ADDON_ACTION_BLOCKEDfor the controller-supportSetCVarat login.taint.logshows only the addon's own call with no earlier taint, so nothing on our side can be cleaned up. The value still changes and the switch works after a reload, and it is needed for streaming to a Steam Deck, so the call stays and the error is accepted. The game's own checkbox reloads the UI when toggled although its Lua has no reload, which suggests the client does it inside the CVar change and refuses that part to an addon. That explanation is not confirmed.For the reviewer
reloadedForControlleris a new optional top-level field inAutoSetupDB; absent means false, so there is noDB_VERSIONbump.luacheckandluac -ppass. Not tested in game yet.