[TechLuddite]

When a host's offer takes the local clipboard, the client did not revoke its previous local offer. watch_local returned early for the server's proxy provider, so no new LocalOffer reached any session, and Bridge::on_request serves file requests from the local_files snapshot after checking only the serial. Every connected host, including a background tab, could still request the last locally copied files by index and receive their current contents. #43 left this gap.

The client now revokes the local offer in every session on each clipboard change, before the file listing and before that early return. A revocation clears the offer, its MIME types and files, and aborts transfers being served. The revocation is local to the client, and #68 adds the message that tells the host. Serials keep increasing across revocations. A file open still in flight during a revocation is refused when it completes, and a serve displaced by a reused request id is aborted. Wire messages are unchanged.

Validation:

• Seven new regressions, each failing with its part of the fix removed: a file request after revocation, a revocation during an in-flight open, an aborted serve, a displaced serve, every session revoked when the host's offer takes the clipboard, serials across revocations, and a normal file offer still served.
• The ignored clipboard test that scripts/e2e.sh runs (step 5b) now drives watch_local with a real RemoteProvider and checks that both of two sessions are revoked. It passed in all eight e2e runs (nested Hyprland, AMD Radeon 840M). The intermittent step 6 failures in those runs are the e2e race that Wait for the client's clipboard item in e2e, not a MIME type #65 fixes.
• scripts/check.sh passes.

#68 builds on this one and offers the local clipboard only to the shown session. This conflicts with #80 in the clipboard bridge. I am happy to rebase whichever lands second.

Opus 5.5 high, on behalf of TechLuddite.
Implemented with Claude Opus 5.5 at high effort and reviewed by GPT-6.1 (Codex) at high reasoning effort over three passes, then re-reviewed on 2026-10-19 by Claude, GPT-6.1 and Grok 4.7 at medium effort.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

The client now withdraws its previous clipboard offer from every session whenever the clipboard changes.

• Clipboard changes revoke the old offer in every session.

TechLuddite explicitly defers notifying the host about revocation to #68. Cancellation on clipboard changes is intentional and documented.

Tests were inspected but not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Clipboard changes] --> B[Send RevokeLocal to every session]
    B --> C[Clear saved offer and stop outgoing transfers]
    B --> D{Clipboard holds RemoteProvider?}
    D -->|Yes| E[Do not offer it back]
    D -->|No| F[Build local offer]
    F --> G{Clipboard changed again?}
    G -->|Yes| H[Drop stale result]
    G -->|No| I[Send LocalOffer with next serial]

Loading

_{Reviews (1) · Last reviewed commit: "Explain clipboard-change cancellation of..." · Reviewed by Greptile}