openclaw: depend on npm at runtime - #490
Open
calledtoconstruct wants to merge 2 commits into
Open
calledtoconstruct wants to merge 2 commits into
calledtoconstruct wants to merge 2 commits into
Conversation
The Gateway user service spawns npm for plugin metadata and updates. mise's npm is not on that unit's PATH, and makedepends does not put /usr/bin/npm on installed systems. Fixes omacom#421
depends already pulls npm into the build chroot, so a second makedepends entry is redundant. Fixes omacom#421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421.
The Gateway user service spawns
npmfor plugin metadata and updates.npmwas only inmakedepends, so/usr/bin/npmis missing on installed systems; mise's npm is not on that unit's PATH.Put
npmindepends. It is also available in the build chroot, so a separatemakedependsentry is not needed.pkgrel1 → 2.Validation:
PATH=/usr/bin:/usr/local/bin:/bin command -v npmis ENOENT on this host.tests/openclaw-runtime-npm.shpasses.