Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11868 (recovery half — the resume-hook atomicity half still needs a maintainer decision).
Problem
omarchy-toggle-hybrid-gpuonly handlesIntegrated/Hybrid. When theforce-igpuresume hook strands the persistent config inVfio(itspoststep doesVfio -> Integratedandsupergfxctl -mpersists each step, so a failed trip back leaves"mode": "Vfio"), the only UI for this —Super+Ctrl+H > Hybrid GPU— dead-ends withHybrid GPU not found or in unknown mode.The user has no guided way out.Observed twice on HP CoffeeLake + GTX 1050 Max-Q (supported modes
[Integrated, Hybrid, Vfio]):UnbindRemoveGpu: No such file or directory+rmmod nvidia_drm failed: Module nvidia_drm is in use→Could not confirm the GPU transition to Integrated mode, config left atVfio,/runmarker gone after reboot.Change
Add a
Vfioarm that offers return toHybridwith the same cleanup theIntegrated -> Hybridpath does (rewrite config toHybrid, removeforce-igpuhook +delay-start.conf, reboot).Vfiois never a resting state from this menu, so this mirrors existing behavior instead of inventing a new flow. Truly unknown modes still hit*).Testing
bash -nclean.supergfxctl=gum=yesrun through theVfiopath: rewrites config toHybrid, removes hook + drop-in, callsomarchy-system-reboot, exit 0.Dedicatedstill exits 1 with the unknown-mode message; declining theHybridconfirm still exits 0 without changes.test/shell.d/hybrid-gpu-test.shandhw-hybrid-gpu-test.sh: all pass../test/all: only pre-existing environment failures (config,locate,snapper,unowned-system-paths— e.g. missingomarchy-pkgscheckout), verified identical on pristineomacom/quattro.