Skip to content

Offer Hybrid recovery from Vfio mode in toggle-hybrid-gpu - #11870

Open
ujo4eva wants to merge 1 commit into
omacom:quattrofrom
ujo4eva:fix/toggle-hybrid-gpu-vfio-recovery
Open

ujo4eva wants to merge 1 commit into
omacom:quattrofrom
ujo4eva:fix/toggle-hybrid-gpu-vfio-recovery

Conversation

@ujo4eva

@ujo4eva ujo4eva commented Sep 15, 2026

Copy link
Copy Markdown

Fixes #11868 (recovery half — the resume-hook atomicity half still needs a maintainer decision).

Problem

omarchy-toggle-hybrid-gpu only handles Integrated/Hybrid. When the force-igpu resume hook strands the persistent config in Vfio (its post step does Vfio -> Integrated and supergfxctl -m persists each step, so a failed trip back leaves "mode": "Vfio"), the only UI for this — Super+Ctrl+H > Hybrid GPU — dead-ends with Hybrid GPU not found or in unknown mode. The user has no guided way out.

Observed twice on HP CoffeeLake + GTX 1050 Max-Q (supported modes [Integrated, Hybrid, Vfio]): UnbindRemoveGpu: No such file or directory + rmmod nvidia_drm failed: Module nvidia_drm is in useCould not confirm the GPU transition to Integrated mode, config left at Vfio, /run marker gone after reboot.

Change

Add a Vfio arm that offers return to Hybrid with the same cleanup the Integrated -> Hybrid path does (rewrite config to Hybrid, remove force-igpu hook + delay-start.conf, reboot). Vfio is never a resting state from this menu, so this mirrors existing behavior instead of inventing a new flow. Truly unknown modes still hit *).

Testing

  • bash -n clean.
  • Stubbed supergfxctl=gum=yes run through the Vfio path: rewrites config to Hybrid, removes hook + drop-in, calls omarchy-system-reboot, exit 0. Dedicated still exits 1 with the unknown-mode message; declining the Hybrid confirm still exits 0 without changes.
  • test/shell.d/hybrid-gpu-test.sh and hw-hybrid-gpu-test.sh: all pass.
  • ./test/all: only pre-existing environment failures (config, locate, snapper, unowned-system-paths — e.g. missing omarchy-pkgs checkout), verified identical on pristine omacom/quattro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

force-igpu resume hook strands system in Vfio mode on Integrated->Vfio transition failure; toggle can't recover

1 participant