Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restarting the shell currently drops the bar's exclusive zone, expands tiled windows into that space, then shrinks them again when the bar returns. That's very disruptive while working.
This PR keeps the built-in bar's space reserved throughout shell restarts and crashes, with a status message in the strip until the shell returns.
A separate Quickshell configuration owns the reservation and loads no plugins or authentication services. The interactive bar occupies the same strip without reserving it twice. Bounded socket messages carry the current screens, edge, size, visibility, colors, and readiness. Explicit restarts, abnormal-exit retries, exhausted retries, and clean stops have distinct messages.
Validation
./test/allpassed: CLI suite and all 239 shell test files. Run withLANG=C.UTF-8,LC_ALLunset, andPYTHONDONTWRITEBYTECODE=1; the VM had a default route for the existing network-interface test.quattroreproduced the issue: the terminal moved from(12,38)to(12,12)and grew from1256×750to1256×776when the bar exited.Scope and tradeoffs
This protects the built-in bar and its hosted plugins. Full replacement bars keep their existing exclusive-zone behavior. The companion itself or the compositor dying can still cause a layout change; the main bar falls back to owning its own zone if the companion disappears. The extra Qt Quick process measured roughly 80 MiB PSS in this VM.
The companion survives main-shell restarts, so changes to its own QML take effect at the next session start. Architecture, lifecycle, and reproducible acceptance-test instructions are in
docs/bar-reservation.md.