fix(network): fall back to Cloudflare speedtest when fast.com is unreachable - #11895
Open
szaidi-code wants to merge 1 commit into
Open
szaidi-code wants to merge 1 commit into
szaidi-code wants to merge 1 commit into
Conversation
…achable Fixes omacom#11816 fast.com returns HTTP 403 or fails to respond in regions outside the US where Netflix does not operate Open Connect CDN nodes, breaking omarchy-network-speedtest down and up. Add a 3-second timeout on the fast.com API probe and fall back to Cloudflare's geo-neutral speed test endpoints (https://speed.cloudflare.com/__down and /__up) when fast.com endpoints cannot be retrieved. Add test/shell.d/network-speedtest-test.sh covering CLI argument validation and fallback behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11816
Description
omarchy-network-speedtestcurrently depends entirely on Netflix'sapi.fast.com. In regions where Netflix does not operate Open Connect CDN nodes (or when the API returns HTTP 403 / is geo-blocked),omarchy-network-speedtest downandupfail immediately withFailed to fetch speed test endpoints.Changes
--max-time 3to the fast.com API probe so it doesn't block the UI indefinitely if the connection hangs.https://speed.cloudflare.com/__down?bytes=25000000for download andhttps://speed.cloudflare.com/__upfor upload), which require no auth and operate globally.test/shell.d/network-speedtest-test.shverifying argument parsing and fallback activation when fast.com is unreachable.Verification
test/shell.d/network-speedtest-test.shon host and inside Arch Linux container (CT 201) — 4/4 checks pass../test/clipasses.