Make omarchy toggle bar on/off match bar visibility - #12150
Open
WoodyWoodster wants to merge 1 commit into
Open
WoodyWoodster wants to merge 1 commit into
WoodyWoodster wants to merge 1 commit into
Conversation
Author
|
Confirming the bug: Testing on with fix: Testing off with fix: |
The wrapper passed on/off through to the bar-off flag, so on hid the bar and off showed it. Fixes omacom#12082
WoodyWoodster
force-pushed
the
fix-toggle-bar-on-off
branch
from
September 16, 2026 18:16
bb5b07f to
498fb44
Compare
|
There are several still-open implementations of this same bar-visibility inversion: #12022, #11807, #11849 and #11894 all update the bar/fullscreen helpers and associated tests. They address overlapping reports #12082, #11817 and #11769. Could one be selected and the others closed as duplicates after consolidating the useful coverage? The explicit invalid-action handling here/#11807 and the implicit/explicit toggle coverage in #11849 are worth retaining alongside the corrected fullscreen and acceptance expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12082
omarchy toggle bar onhid the bar andoffshowed it, because the wrapper passed those arguments straight through to thebar-offflag. User-facingon/offnow means bar visibility.omarchy-toggle-fullscreen-desktophides the bar withomarchy-toggle-bar offso fullscreen on/off stay correct.The on-disk flag is still
bar-off. Menu and hotkey callers pass no argument, so they are unaffected.Testing
bash test/shell.d/toggle-test.sh—onclearsbar-off,offsets it, and fullscreen still enters and leaves togetherenv -u NO_COLOR PYTHONDONTWRITEBYTECODE=1 ./test/all— all 238 shell test files passedPATH: packagedomarchy-toggle-bar onstill hides (the bug); checkoutonshows,offhides;omarchy-toggle-fullscreen-desktop onhides the bar andoffrestores itAcceptance (
test/acceptance.d/session-test.sh) is updated for the new mapping. That suite runs in a disposable VM, not the development session, so it is not in this run.