Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
On the macOS ANGLE/VirGL path, QEMU waits 10 ms before polling pending GPU fences again. That exceeds the 8.33 ms frame period of a 120 Hz display and can delay guest progress into a later frame.
Add a checksum-pinned QEMU source patch that uses a 1 ms interval under
CONFIG_DARWIN. Other platforms retain 10 ms, and the existing pending command/fence queue check still controls timer rearming. No guest protocol or package changes are required.This overlaps with the GPU fence polling portion of #168 and follows its Darwin-scoped implementation. It intentionally leaves the display refresh timestamp change, HDR, video decoding, and audio timer changes to that PR.
Existing experimental evidence
A controlled 10 ms → 1 ms → 10 ms comparison on an M3 Max, using a native Wayland/EGL client with presentation feedback, produced:
At 60 Hz, both intervals sustained approximately 60 presentations/s. Simple clears and a workload with 200 scissored rectangle clears showed the same pattern. Runs lasted 12 seconds and excluded the first two seconds from steady-state summaries.
These measure guest virtual-display presentation, not physical panel scanout or end-to-end input latency. The isolated A/B/A experiment used a diagnostic binary modification; it is supporting evidence, not validation of the final source-built package. A later source-built integration of #168 also reached approximately 120 presentations/s, but included other display changes.
Validation and draft status
make testpassed using the installed Xcode toolchain, including 242 Swift tests in 54 suites and the guest, build/cache, shell, and storage checks. The initial Command Line Tools run failed to load Swift Testing macros; the Xcode rerun resolved that toolchain issue.Before marking ready:
More frequent polling can increase CPU usage and wakeups while GPU work remains pending. This PR remains a draft until the standalone runtime and that tradeoff are validated.