Confine managed mount setup to subordinate authority by omry · Pull Request #325 · omry/reploy

omry · 2026-11-03T22:04:59Z

Run one fixed setup helper under freshly checked selected UID/GID maps. Transfer verified held descriptors only after helper retirement.

Reuse existing mapping/effect admission and object preparation. Qualify sparse ownership, recipient access, cancellation, authority drift and parent death on an isolated Linux guest.

Run one fixed setup helper under freshly checked selected UID/GID maps. Transfer verified held descriptors only after helper retirement. Reuse existing mapping/effect admission and object preparation. Qualify sparse ownership, recipient access, cancellation, authority drift and parent death on an isolated Linux guest.

gitar-bot · 2026-11-03T22:08:18Z

Code Review ✅ Approved

🔴 High risk · The new subordinate-map setup changes managed-mount ownership and modes; incorrect metadata could expose private files to unintended recipients.

Confines managed mount setup to a subordinate authority by running one fixed setup helper under freshly checked selected UID/GID maps, and transfers verified held descriptors only after helper retirement. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

omry · 2026-11-03T22:12:03Z

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)

{
  "approval": {
    "candidate_revision_fingerprint": "sha256:3130a930125a2df18882066031dff9fb7a81ca814826781c10b1f0dad6ed6ceb",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:3130a930125a2df18882066031dff9fb7a81ca814826781c10b1f0dad6ed6ceb",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 126246720238
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 126236358716
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 126236342943
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 126236343473
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 126236343829
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 126236343819
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 126236343670
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 126236343687
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 126236343922
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:b67056317b9818bac3e1dff5892914effe382d9f6842864fe5b4a4140ac00c9b",
      "review_request": {
        "body_digest": "sha256:553cb04613cc527248d5ecc77556d46299e200ccc3925f12cd44d380b1cff485",
        "id": 6616779001
      },
      "review_result": {
        "body_digest": "sha256:4bc7420c252884d6a640cdc7552b24a45c80b2eb9c7513db95b91624b7ad3b11",
        "id": 6616809810
      }
    },
    "evidence_fingerprint": "sha256:caeadf0b078df4fcc673a39b642b60119e215a4116a4244d3b690a7d0e081d8f",
    "head_sha": "785c537f0c17df7021c48d54c368ab45a7782cf2",
    "operation_identity": "sha256:b67056317b9818bac3e1dff5892914effe382d9f6842864fe5b4a4140ac00c9b",
    "review_request_id": 6616779001,
    "review_result_id": 6616809810,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:3130a930125a2df18882066031dff9fb7a81ca814826781c10b1f0dad6ed6ceb",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Bash native evidence checks",
      "run_id": 126246720238
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 126236358716
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks",
      "run_id": 126236342943
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)",
      "run_id": 126236343473
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)",
      "run_id": 126236343829
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)",
      "run_id": 126236343819
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)",
      "run_id": 126236343670
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)",
      "run_id": 126236343687
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)",
      "run_id": 126236343922
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 126246720238,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126246720238"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 126236358716,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/126236358716"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 126236342943,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236342943"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 126236343473,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343473"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 126236343829,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343829"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 126236343819,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343819"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 126236343670,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343670"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 126236343687,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343687"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 126236343922,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41727591338/job/126236343922"
        }
      ],
      "head_sha": "785c537f0c17df7021c48d54c368ab45a7782cf2",
      "id": "sha256:6de821db3f10d317c554180aa6347d74e9a4f5e8078072cc0bc64d2f4f15a798",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr324",
    "base_sha": "8d12833c695c850ff3d5ce560f4b53a09c99ed82",
    "body_digest": "sha256:376c97fe438cc62ae3d6fc0cdb39700ddb0f89b515377cda45bba2434a6227da",
    "body_identity_version": 2,
    "diff_digest": "sha256:e1da85240623db2ab34bdb937d3f9a6646821bb6adeb44f2a4c8dd5b328116f7",
    "head_ref": "pr325",
    "head_sha": "785c537f0c17df7021c48d54c368ab45a7782cf2",
    "pr": 325,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:fc49790f85e6d5fae77e8c91b479d0ad1fe4b3f1699e24df821db73aa75b779e",
        "path": "AGENTS.md"
      },
      {
        "digest": "sha256:6f278d93ec80c42f9b905f990c585c1c9db7082cd7e7c2a827e9b840582b6c14",
        "path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
      },
      {
        "digest": "sha256:f6049a45f86b96b5a7c6616926804871d77e8b86bf3305cc42d3910320fc5b76",
        "path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
      },
      {
        "digest": "sha256:8a073c695effc36a3c2fd2baba3d8fcf85627e152968682154833270da627a5e",
        "path": "docs/supporting/MULTI_IDENTITY_IMPLEMENTATION_PLAN/fg-sizing-basis.md"
      }
    ],
    "title_digest": "sha256:77cd85ccb148bf1b48fc6564ee60b051857e0500aef59d3e2d5bc4273addaeca"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-11-03T22:05:02Z",
      "base_ref": "pr324",
      "base_sha": "8d12833c695c850ff3d5ce560f4b53a09c99ed82",
      "body_digest": "sha256:553cb04613cc527248d5ecc77556d46299e200ccc3925f12cd44d380b1cff485",
      "created_at": "2026-11-03T22:16:00Z",
      "head_sha": "785c537f0c17df7021c48d54c368ab45a7782cf2",
      "id": 6616779001,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr324",
      "base_sha": "8d12833c695c850ff3d5ce560f4b53a09c99ed82",
      "body_digest": "sha256:4bc7420c252884d6a640cdc7552b24a45c80b2eb9c7513db95b91624b7ad3b11",
      "commit_id": "785c537f0c17df7021c48d54c368ab45a7782cf2",
      "id": 6616809810,
      "inline_message_ids": [],
      "request_comment_id": 6616779001,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-11-03T22:17:41Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:3130a930125a2df18882066031dff9fb7a81ca814826781c10b1f0dad6ed6ceb",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:e1da85240623db2ab34bdb937d3f9a6646821bb6adeb44f2a4c8dd5b328116f7",
      "finding_ids": [],
      "invariants": [
        "F1.3 confines inert preparation to exact freshly checked selected subordinate UID/GID geometry, pinned descriptors and numeric metadata.",
        "Cancellation, authority drift and parent death retire setup authority; foreign metadata and application execution remain excluded.",
        "Public mapped activation remains inhibited until later integration and qualification."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "785c537f0c17df7021c48d54c368ab45a7782cf2",
      "review_observation_id": null,
      "review_request_id": 6616779001,
      "review_result_id": 6616809810,
      "reviewed_head": "785c537f0c17df7021c48d54c368ab45a7782cf2",
      "root_cause": "No defect or source correction in this PR round. Exact-head remote review is clean; all nine checks and all13 fresh local commands pass. Original fixed growth inputs and 365-line scope remain unchanged; enforcement permits advance.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

chatgpt-codex-connector · 2026-11-03T22:12:49Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-03T22:17:42.545231Z	`785c537`	Manual request
🔒 Security Review	⚠️ Failed 2026-11-03T22:12:46.658828Z We couldn’t complete this review. Comment `@codex security review` to try again.	`785c537`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-11-03T22:12:51Z

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

omry · 2026-11-03T22:16:00Z

@codex review

Exact head: 785c537

chatgpt-codex-connector · 2026-11-03T22:17:41Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 785c537f0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry changed the base branch from main to pr324 November 3, 2026 22:05

omry added this pull request to stack #321 November 3, 2026 22:05

omry marked this pull request as ready for review November 3, 2026 22:12

omry added the approved PR reviewed and approved label Nov 3, 2026

Navigation Menu

Repository navigation

Confine managed mount setup to subordinate authority - #325

Confine managed mount setup to subordinate authority#325
omry wants to merge 1 commit into
pr324from
pr325

omry commented Nov 3, 2026 •

edited

Loading

Uh oh!

gitar-bot Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

omry commented Nov 3, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026

Uh oh!

omry commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

omry commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitar-bot Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omry commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026

Uh oh!

omry commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

omry commented Nov 3, 2026 •

edited

Loading

gitar-bot Bot commented Nov 3, 2026 •

edited

Loading

omry commented Nov 3, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading