F2.1.2: Record managed storage state and transactions by omry · Pull Request #327 · omry/reploy

omry · 2026-11-05T08:34:37Z

Record managed storage ownership and operation selections in the existing StateV1 codec and mapping journal. Route preparation, attachment, result verification and recovery through the sole mapping writer and existing OperationLock. Require fresh typed resource observations and preserve inhibition and reservations for unknown or incomplete results.

Reuse the approved deploy-layer source and tests on the accepted helper predecessor. This provides the journal component for the following Linux adapter integration. Engine/controller fencing, public mapped activation and original F21-SOL-001 closure remain outside this component.

Record managed storage ownership and operation selections in the existing StateV1 codec and mapping journal. Route preparation, attachment, result verification and recovery through the sole mapping writer and existing OperationLock. Require fresh typed resource observations and preserve inhibition and reservations for unknown or incomplete results. Reuse the approved deploy-layer source and tests on the accepted helper predecessor. This provides the journal component for the following Linux adapter integration. Engine/controller fencing, public mapped activation and original F21-SOL-001 closure remain outside this component.

gitar-bot · 2026-11-05T08:36:24Z

Code Review ✅ Approved

🟡 Medium risk · Adding durable managed-storage ownership and attachment transactions could misassociate resources, affecting later reservation and recovery decisions.

Records managed storage ownership and operation selections in the existing StateV1 codec and mapping journal, routing preparation, attachment, verification and recovery through the sole mapping writer and OperationLock. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

omry · 2026-11-05T09:30:21Z

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)

{
  "approval": {
    "candidate_revision_fingerprint": "sha256:25599f7ee466b6019e66d78069a0687c12030f8bb6502d22fd4951b7e58e79c5",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:25599f7ee466b6019e66d78069a0687c12030f8bb6502d22fd4951b7e58e79c5",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 127145292520
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 127137705617
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 127137699624
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 127137700108
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 127137700157
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 127137700305
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 127137700192
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 127137700162
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 127137700189
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:74d1e4be2da4e99d154fdf2ddca4b2fdc38b769a2b84b9269ac6a129c6f201a3",
      "review_request": {
        "body_digest": "sha256:ca297b3efd8a804e87f23bfbc61d1058fc99591e8c48fafeb8c783474a78e093",
        "id": 6654579954
      },
      "review_result": {
        "body_digest": "sha256:7c7b84b7e30bb3233ff8bb8e87a220e63894b0b5e8c891ca26fbd66f9af9b58d",
        "id": 6654610477
      }
    },
    "evidence_fingerprint": "sha256:c01d5251bd8dc1ef0c3c400685907c2114b28a17b62d6c06e058df0671395877",
    "head_sha": "82394a8758b08469fff7de01e2603cb96c8d0118",
    "operation_identity": "sha256:74d1e4be2da4e99d154fdf2ddca4b2fdc38b769a2b84b9269ac6a129c6f201a3",
    "review_request_id": 6654579954,
    "review_result_id": 6654610477,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:25599f7ee466b6019e66d78069a0687c12030f8bb6502d22fd4951b7e58e79c5",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Bash native evidence checks",
      "run_id": 127145292520
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 127137705617
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks",
      "run_id": 127137699624
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)",
      "run_id": 127137700108
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)",
      "run_id": 127137700157
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)",
      "run_id": 127137700305
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)",
      "run_id": 127137700192
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)",
      "run_id": 127137700162
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)",
      "run_id": 127137700189
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 127145292520,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127145292520"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 127137705617,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/127137705617"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 127137699624,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137699624"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 127137700108,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700108"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 127137700157,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700157"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 127137700305,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700305"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 127137700192,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700192"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 127137700162,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700162"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 127137700189,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41995547063/job/127137700189"
        }
      ],
      "head_sha": "82394a8758b08469fff7de01e2603cb96c8d0118",
      "id": "sha256:751d6bb270c89e22df0affb7319341f5df625442b17126aa0cc50f827898cd3e",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr326",
    "base_sha": "851f76b2c8df61f7735b682e8e4356183ae90804",
    "body_digest": "sha256:552b9f35433e6a677cc5e744600a548c939ac85e4a60a6a872e850713ee0abd9",
    "body_identity_version": 2,
    "diff_digest": "sha256:2915d28ed227dba1915078f67771ffa5118a8da1c711a5ec672314510e6211a8",
    "head_ref": "pr327",
    "head_sha": "82394a8758b08469fff7de01e2603cb96c8d0118",
    "pr": 327,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
        "path": "docs/MULTI_IDENTITY_D_DESIGN.md"
      },
      {
        "digest": "sha256:7757ebe99b2135d9c7bf78ab29c844c2f1d956420a9fab6fea9dcdd0986f40a8",
        "path": "docs/MULTI_IDENTITY_E_DESIGN.md"
      },
      {
        "digest": "sha256:6f278d93ec80c42f9b905f990c585c1c9db7082cd7e7c2a827e9b840582b6c14",
        "path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
      },
      {
        "digest": "sha256:78f9f1a1de6098b2b5653c5cd10096e7b0e5023230b1e9365638e317cc64fb95",
        "path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
      },
      {
        "digest": "sha256:f6049a45f86b96b5a7c6616926804871d77e8b86bf3305cc42d3910320fc5b76",
        "path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
      },
      {
        "digest": "sha256:728d53f86612af0d6ba45c3d0fe84e61b41ac5e4f622b43132d2314775e389ab",
        "path": "docs/supporting/MULTI_IDENTITY_IMPLEMENTATION_PLAN/fg-controller-slice-forecast.json"
      },
      {
        "digest": "sha256:3013953a1cafa68f6b1175818a167fab5d61f406970a9f0c61621e23d8809e98",
        "path": "docs/supporting/MULTI_IDENTITY_IMPLEMENTATION_PLAN/fg-prerequisite-audit.md"
      },
      {
        "digest": "sha256:8a073c695effc36a3c2fd2baba3d8fcf85627e152968682154833270da627a5e",
        "path": "docs/supporting/MULTI_IDENTITY_IMPLEMENTATION_PLAN/fg-sizing-basis.md"
      }
    ],
    "title_digest": "sha256:857f35ffaea46489cbf41fd269f4a254a43a440e0e823c7ac81923b4d1d24776"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-11-05T08:34:37Z",
      "base_ref": "pr326",
      "base_sha": "851f76b2c8df61f7735b682e8e4356183ae90804",
      "body_digest": "sha256:ca297b3efd8a804e87f23bfbc61d1058fc99591e8c48fafeb8c783474a78e093",
      "created_at": "2026-11-05T09:34:04Z",
      "head_sha": "82394a8758b08469fff7de01e2603cb96c8d0118",
      "id": 6654579954,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr326",
      "base_sha": "851f76b2c8df61f7735b682e8e4356183ae90804",
      "body_digest": "sha256:7c7b84b7e30bb3233ff8bb8e87a220e63894b0b5e8c891ca26fbd66f9af9b58d",
      "commit_id": "82394a8758b08469fff7de01e2603cb96c8d0118",
      "id": 6654610477,
      "inline_message_ids": [],
      "request_comment_id": 6654579954,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-11-05T09:35:31Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:25599f7ee466b6019e66d78069a0687c12030f8bb6502d22fd4951b7e58e79c5",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:2915d28ed227dba1915078f67771ffa5118a8da1c711a5ec672314510e6211a8",
      "finding_ids": [],
      "invariants": [
        "Managed storage retains exact owned handles, complete canonical object inventories, selected geometry and generation/revision binding through the existing sole writer and OperationLock.",
        "Fresh trusted typed observation guards intent, effects, result, cancellation and recovery; unknown or partial effects retain inhibition and reservations without replay.",
        "Journal completion grants no native admission, physical adapter qualification or controller fencing; those responsibilities remain separately assigned."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "82394a8758b08469fff7de01e2603cb96c8d0118",
      "review_observation_id": null,
      "review_request_id": 6654579954,
      "review_result_id": 6654610477,
      "reviewed_head": "82394a8758b08469fff7de01e2603cb96c8d0118",
      "root_cause": "No defect or correction. Current head/base Codex review is clean; all8 required CI plus Gitar succeeded; all13 fresh local commands passed and original full independent review remains bound to exact source and authority.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

chatgpt-codex-connector · 2026-11-05T09:31:00Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-05T09:35:33.127629Z	`82394a8`	Manual request
🔒 Security Review	✅ Completed 2026-11-05T09:34:23.305606Z	`82394a8`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

omry · 2026-11-05T09:34:04Z

@codex review

Exact head: 82394a8

chatgpt-codex-connector · 2026-11-05T09:35:31Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 82394a8758

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry mentioned this pull request Nov 5, 2026

F2.1.1: Inspect retained managed mount paths without mutation #326

Open

omry added this pull request to stack #321 November 5, 2026 08:34

omry marked this pull request as ready for review November 5, 2026 09:30

omry added the approved PR reviewed and approved label Nov 5, 2026

Navigation Menu

Repository navigation

F2.1.2: Record managed storage state and transactions - #327

F2.1.2: Record managed storage state and transactions#327
omry wants to merge 1 commit into
pr326from
pr327

omry commented Nov 5, 2026 •

edited

Loading

Uh oh!

gitar-bot Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

omry commented Nov 5, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

omry commented Nov 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 5, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

omry commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitar-bot Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omry commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

omry commented Nov 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 5, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

omry commented Nov 5, 2026 •

edited

Loading

gitar-bot Bot commented Nov 5, 2026 •

edited

Loading

omry commented Nov 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 5, 2026 •

edited

Loading