Allow enabling of monitor during upload of a new firmware in the cli #74

Activity

1. martonilles commented on Jul 17, 2026

   

   martonilles

   on Jul 17, 2026

   Contributor

   More actions

   This is already possible, but setting the enable_monitoring flag to True:

       def upload_firmware(
           self,
           metadata: m.FirmwareMetadata,
           path: Path | None,
           *,
           sbom_path: Path | None = None,
           enable_monitoring: bool,
           timeout=60,
       ):
   
2. martonilles

   closed this as completedon Jul 17, 2026
3. CMon commented on Aug 12, 2026

   

   CMon

   on Aug 12, 2026

   Author

   More actions

   Yes I found it inside your class but not exposed to the cli itself, since I use your pip package in my CI's there the def upload_firmware from : onekey_client/cli/firmware_upload.py#L42 will be used, which does not allow setting enable_monitoring
4. martonilles commented on Aug 14, 2026

   

   martonilles

   on Aug 14, 2026

   Contributor

   More actions

   Sorry, it was not clear you were referring to the cli
5. martonilles

   reopened this on Aug 14, 2026
6. martonilles

   changed the title [-]Allow enabling of monitor during upload of a new firmware[/-] [+]Allow enabling of monitor during upload of a new firmware in the cli[/+] on Aug 14, 2026
7. martonilles commented on Aug 26, 2026

   

   martonilles

   on Aug 26, 2026

   Contributor

   More actions

   Done in #79
8. martonilles

   closed this as completedon Aug 26, 2026