Repository navigation
Conversation
…Homogenization.lean Co-authored-by: M. Winter <112132359+martinwintermath@users.noreply.github.com>
| structure Face (P : ConvexSet R M) extends toConvexSet : ConvexSet R M where | ||
| isFaceOf : IsFaceOf toConvexSet P | ||
| @[ext] | ||
| structure Face {p : Set M} (P : IsConvexSet R p) where |
There was a problem hiding this comment.
| structure Face {p : Set M} (P : IsConvexSet R p) where | |
| structure Face {p : Set M} where |
This seems unneccesary.
There was a problem hiding this comment.
we don't get reflexivity if p is not convex
There was a problem hiding this comment.
Then we need to assume convexity in the reflexivity lemma
There was a problem hiding this comment.
we do assume it for IsFaceOf.refl, but to define the lattice structure i think we don't want to carry the assumption separately. otherwise we'd need stuff like
instance (h : IsConvexSet R P) : OrderTop (Face P) where
and everything gets non-inferrable
There was a problem hiding this comment.
sorry i didnt see my own response below ^^
| namespace IsConvexSet | ||
|
|
||
| /- NOTE: maybe this should be defined on `Set` instead of `ConvexSet`. -/ | ||
| /-- A face of a convex set `P`. Represents the face lattice of `P`. -/ |
There was a problem hiding this comment.
| /-- A face of a convex set `P`. Represents the face lattice of `P`. -/ | |
| /-- A face of a set `P`. This type also represents the face lattice of `P`. -/ |
Co-authored-by: M. Winter <112132359+martinwintermath@users.noreply.github.com>
|
well we are, but how will we define the lattice on `Face` if top and sinf have an additional assumption?
…On 22 October 2026 12:26:58 CEST, "M. Winter" ***@***.***> wrote:
@martinwintermath commented on this pull request.
> /-- A face of a convex set `P`. Represents the face lattice of `P`. -/
-structure Face (P : ConvexSet R M) extends toConvexSet : ConvexSet R M where
- isFaceOf : IsFaceOf toConvexSet P
***@***.***
+structure Face {p : Set M} (P : IsConvexSet R p) where
Then we need to assume convexity in the reflexivity lemma
--
Reply to this email directly or view it on GitHub:
#112 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I don't know. This is a good question and a challenge. Maybe this indicates that bundled objects should be built on other bundled objects, that is, @YaelDillies Any ideas? It seems we can't do with bundles and we can't do without. |
|
Here is a stupid solution: we define Update. here is a less hacked way: we know how to define faces if |
i think your new definition also has oddities. for instance, one might expect the straight line inside the U to be a face. like the black line in this plot which i got from this stackexchange question. i thought we decided somewhere to not try and define faces for non-convex sets? what do you mean by "Let's maybe focus on IsFaceOf for now and lets see how far we get with it?"? we will need the bundled face for the iso to pointed cone faces, so i think we should keep it. what is the problem you see with assuming convexity for the bundled type? |
This was already a problem for the current definition. And I do not consider this line as a face in the convex sets anyway.
Yes, we don't. We try to find a definition on all sets that behaves as expected on convex sets.
Do we though? We have lemmas that transfer
But again, we need to be open for the possibility that |
|
We have at least the following options how to proceed:
I cannot foresee the ramifications of either choice and therefore think we need to pick one for now and see what happens (and be willing to adjust when it turns out necessary). The redefinition of |
|
Option 1 looks most sensible to me right now |
attempting to remove bundled convex sets. wip, some renaming and moving of lemmas needs to be done. wdyt?
IsFaceOfis just extreme subsetsFacerequires both face and faced set to be convex (otherwise its not very interesting and we'd need to define this lattice anyways for homogenization)homogenizeanddehomognizeare both defined on general sets. in particular, we need the assumption of convexity fordehomogenize ℋ (homogenize ℋ P) = P. the order equivalence becomes