Skip to content

Unify deployment rendering and honor OPENSHIFT_PROJECT #33

Description

@caxu-rh

Problem

The deploy Make target mutates the tracked config/manager kustomization with kustomize edit set image, while rebuild-deploy-openshift copies configuration to a temporary directory before rendering. The two paths have different safety and working-tree behavior.

Also, OPENSHIFT_PROJECT affects BuildConfig and rollout commands, but config/default/kustomization.yaml fixes the Kubernetes namespace to guestcluster-operator-system. The documented project override is therefore incomplete.

References

  • Makefile:58
  • Makefile:249-267
  • config/default/kustomization.yaml:2

Suggested direction

Use one safe, temporary rendering path for both deployment targets. Ensure the OpenShift project override also controls the rendered namespace, or document and validate the separate namespace behavior explicitly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions