build(deps)!: Upgrade to opentelemetry 0.32 - #23
Conversation
|
I want to test this in my setup using a hot patch in our nonprod-setup, I'll report back whether it works - tests are passing on my local dev machine. |
|
I can confirm that this works on a nonprod deployment, I used # Hotpatch: point at jens1o's fork until open-schnick/DatadogFormattingLayer#23
# is merged and a v8 release lands on crates.io.
datadog-formatting-layer = { git = "https://github.com/jens1o/DatadogFormattingLayer.git", rev = "098c2c0bc1dbe0a8b2ff33fbbc131fb92c016dbc" }
# Pinned to match the versions that `datadog-formatting-layer` (PR #23, v8) was
# compiled against. Bumping past these splits the OTel global state into
# two parallel copies and breaks trace ↔ log correlation (the dd layer
# can no longer find the `OtelData` extension the layer wrote in).
opentelemetry = "0.32"
opentelemetry_sdk = { version = "0.32", features = ["rt-tokio"] }
opentelemetry-datadog = { version = "0.20", features = [
"reqwest-blocking-client",
] }
tracing-opentelemetry = "0.33" |
|
Hey @open-schnick, Thanks for your feedback. I'm sorry for the late reply, I was out sick and hence out of office. Yes, I did test it using my fork. |
|
I'll fix the conflict later this day. |
|
I'd like to test this again with the other dependency upgrades, I'll come back to you when it works. :) Please don't merge yet. |
923f6c1 to
a206522
Compare
|
I can confirm logs, tracing and log-tracing-correlation still work on commit Feel free to review :) |
|
Looks good to me :) |
BREAKING CHANGE: upgrading the otel version is deemed as breaking as the otel code might break downstream code silently
8f99b2a to
70d18d6
Compare
|
Sure thing, I have done as such. :) I still have the README change in my commit, I think that's okay. |
Upgrades the OTel dependency stack to
opentelemetry 0.32/tracing-opentelemetry 0.33and bumps the crate to 8.0.0 per the established "OTel minor = breaking" policy.There was a breaking change in
tracing-opentelemetry, see https://github.com/tokio-rs/tracing-opentelemetry/releases/tag/v0.33.0 - I oriented myself after this example to see how they suggest it: https://github.com/tokio-rs/tracing-opentelemetry/blob/1d5422f1f37932fd65e434da618b305d4c94ee9c/examples/otel_context.rs