feat(codex-security): allow Deep discovery model overrides - #816
Open
daneschneider-oai wants to merge 1 commit into
Open
feat(codex-security): allow Deep discovery model overrides#816daneschneider-oai wants to merge 1 commit into
daneschneider-oai wants to merge 1 commit into
Conversation
daneschneider-oai
marked this pull request as ready for review
September 7, 2026 05:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Deep Security Scan discovery workers to use optional model and reasoning effort settings. Unset settings continue to inherit the parent scan's choices.
Changes
discovery_modelanddiscovery_reasoning_effortfrom[deep_scan]configuration, snapshot the selected values when a scan starts, and persist them in nullable migration 42 columns for resumed runs.Testing
Risk and rollout
The migration adds nullable columns and keeps existing Deep Scan defaults. Existing scans without overrides continue inheriting their parent settings; configured scans preserve their values on resume. The model and effort values are passed to the existing Codex SDK worker options. This draft is ready for owner review and the repository's CI checks before merge.
Public disclosure review