Skip to content

refactor: call the implicit release line the main line - #749

Merged
akila-i merged 1 commit into
openchoreo:mainfrom
chathuranga95:refactor/main-releaseline
Oct 28, 2026
Merged

akila-i merged 1 commit into
openchoreo:mainfrom
chathuranga95:refactor/main-releaseline

Conversation

@chathuranga95

@chathuranga95 chathuranga95 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The logs, tracing, metrics and FinOps adapters call a component's implicit release line the main line, as OpenChoreo does. Only comments, test names and API descriptions change, and the generated code is regenerated from OpenChoreo's adapter specs.

Purpose

The implicit release line of an openchoreo component is named main instead of default. This PR refactors the rename where applicable.

Approach

Summarize the solution and implementation details.

Related Issues

openchoreo/openchoreo#5024
Related PR: #748

Checklist

  • Tests added or updated (unit, integration, etc.)
  • Samples updated (if applicable)

Summary by CodeRabbit

  • Documentation
    • Updated terminology across release-line descriptions, replacing “default line” with “main line.”
  • Tests
    • Revised test labels and messages to use the updated terminology; test behavior and expectations remain unchanged.

The logs, tracing, metrics and FinOps adapters call a component's
implicit release line the main line, as OpenChoreo does. Only
comments, test names and API descriptions change, and the generated
code is regenerated from OpenChoreo's adapter specs.

Signed-off-by: chathuranga95 <siriwardhanachathuranga@gmail.com>
@chathuranga95
chathuranga95 marked this pull request as ready for review October 28, 2026 07:56
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7ebfeaad-158c-4a61-b044-d3be75870156
Commits

Reviewing files that changed from the base of the PR and between 1fa05b1 and 34c8c23.

Files ignored due to path filters: 8
  • finops-opencost/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • finops-opencost/internal/api/gen/server.gen.go is excluded by !**/gen/**
  • observability-logs-opensearch/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • observability-logs-opensearch/internal/api/gen/server.gen.go is excluded by !**/gen/**
  • observability-metrics-prometheus/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • observability-metrics-prometheus/internal/api/gen/server.gen.go is excluded by !**/gen/**
  • observability-tracing-opensearch/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • observability-tracing-opensearch/internal/api/gen/server.gen.go is excluded by !**/gen/**
Files selected for processing: 20
  • finops-opencost/internal/handlers.go
  • finops-opencost/internal/observer/types.go
  • finops-opencost/internal/opencost/queries.go
  • finops-opencost/internal/opencost/queries_test.go
  • finops-opencost/internal/opencost/releaseline_test.go
  • finops-opencost/internal/releaseline_test.go
  • observability-logs-opensearch/internal/handlers.go
  • observability-logs-opensearch/internal/opensearch/event_types.go
  • observability-logs-opensearch/internal/opensearch/queries.go
  • observability-logs-opensearch/internal/opensearch/release_line_test.go
  • observability-logs-opensearch/internal/opensearch/types.go
  • observability-logs-opensearch/internal/release_line_handlers_test.go
  • observability-metrics-prometheus/internal/prometheus/queries.go
  • observability-metrics-prometheus/internal/prometheus/queries_test.go
  • observability-metrics-prometheus/internal/prometheus/release_line_test.go
  • observability-metrics-prometheus/internal/release_line_handlers_test.go
  • observability-tracing-opensearch/internal/opensearch/queries.go
  • observability-tracing-opensearch/internal/opensearch/release_line_test.go
  • observability-tracing-opensearch/internal/opensearch/types.go
  • observability-tracing-opensearch/internal/release_line_handlers_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Comments and test descriptions across FinOps and observability modules now refer to the component’s “main line” instead of its “default line.” No executable behavior changes are reported. One Prometheus test expectation now uses an empty release-line UID label.

Changes: Release-line terminology alignment

Layer / File(s) Summary
Align terminology and test expectations
finops-opencost/internal/..., observability-logs-opensearch/internal/..., observability-metrics-prometheus/internal/..., observability-tracing-opensearch/internal/...
Comments, test names, and failure messages now use “main line” terminology. One Prometheus pod-label test expectation uses an empty release-line UID label.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Possibly related issues

  • openchoreo/openchoreo issue 5172: This change updates descriptions and test labels to use “main line” for the implicit release line.

Possibly related PRs

Suggested reviewers: nilushancosta, akila-i

Merge Risk: Minimal · up to 34c8c

No actionable merge-blocking risk is established; the PR is limited to terminology alignment and matching test descriptions.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 47.83% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description check Passed The description includes the required Purpose, Approach, Related Issues, and Checklist sections. The Approach section retains placeholder text, and the optional Remarks section is missing, but the sur…
Title check Passed The title uses Conventional Commits format and clearly describes the terminology change from the implicit release line to the main line.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Purpose, Approach, Related Issues, and Checklist sections. The Approach section retains placeholder text, and the optional Remarks section is missing, but the surrounding summary provides the implementation context.

Full details: Docstring Coverage

Explanation

Docstring coverage is 47.83% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 23 functions across 20 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chathuranga95
chathuranga95 requested a review from akila-i October 28, 2026 07:56
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@akila-i
akila-i merged commit c53adf9 into openchoreo:main Oct 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants