Skip to content

fix(jsc): retain syntax-selected stack source positions - #3

Merged
steipete merged 6 commits into
openclaw/mainfrom
claude/w146-stack-positions
Oct 4, 2026
Merged

steipete merged 6 commits into
openclaw/mainfrom
claude/w146-stack-positions

Conversation

@steipete

@steipete steipete commented Oct 4, 2026 •

Copy link
Copy Markdown

Make JSC stack positions select the same syntax tokens as Node 24: call and constructor starts, property reads, and async await continuations. Keep those positions separate from exception-expression divots and debugger line tables. Both captured StackFrame and live StackVisitor readers use the metadata; executable line overrides and release-private builtin position policy are preserved.

The two sparse vectors are owned by each unlinked code block, remapped through bytecode rewriting/optimization, and decoded into owned storage on both cache paths. The cache revision advances with the metadata. Property reads and calls retain distinct tokens, so (null.x)() can fail at x before reaching the call.

The paired Bun adapter in openclaw/bun#114 also preserves error constructors and runtime call syntax. Rewriting new Error() into Error() moved the reported column and made a returning arrow eligible for JSC proper-tail-call elision. Preserving new restores the frame without disabling tail calls. Callee parentheses, computed access, and opening delimiter mappings are required for the broader normal-transpile corpus; TypeScript generic/non-null suffixes and cache invalidation are covered.

This continues the source-position work in oven-sh/bun#35179, #37396, and #41580 by @robobun.

Native Linux qualification on one c7a.24xlarge host, with the unchanged W113 lane/Docker/ICU recipe:

  • 1,509,853 FFI checks; 121 JSC stress configurations; interpreter/JIT/bytecode-optimizer/eager-FTL modes; owned and persistent cold/warm caches. Each cache path creates three files totaling 33,024 bytes.
  • Raw JSC positions improve from 13/30 to 30/30 in the call corpus and from 4/28 to 28/28 in the added cases. The live visitor matches Node at 1:22, 2:21, 3:1. Async continuation control passes.
  • Paired Bun: 47/47 fork-selection results with zero regressions, 343 CallSite/util/source-map tests, and 68 minifier tests. Normal transpilation matches all 30 call shapes, all 28 added cases on both stack surfaces, and 14 TypeScript/generic/non-null/astral cases. The JavaScript/TypeScript module corpus and 58 raw-eval rows match as well.
  • Runtime cache replacement and warm replay match all 56 added observations. Existing custom-stack generated-versus-mapped and filename/eval-origin policies are preserved.
  • OpenClaw loader pair 8/8, SDK under its existing native-loader policy 67 pass/1 skip, Slack ordered shared-worker sequence 26/26, and real Proxyline probe pass. The original shared SDK policy retains its same two baseline tsconfig resolver failures.
  • ABBA, eight samples per arm: exception creation/formatting +7.6%; fresh 350-module startup 0.998× baseline. The exception overhead is an explicit tradeoff.
  • Final complete engine and Bun branch reviews are scoped-clean through P2. Exact-head CI run 37240058657 is green at 6e69d757023aa75398a670f487f90fe2a57e2b99.

Qualification caught and corrected a namespace-only result-checker assumption, repeated C++ default arguments in unity builds, private-builtin position leakage, missing transpiler delimiter metadata, TypeScript non-null suffix tracking, and the omitted live-stack reader. Exact position goldens were checked against Node; the original astral inline-snapshot assertion remains intact and passes.

The Bun draft remains stacked on manifest commit cf636c2f14914b3ba4b319874312d654cc5ea064 and also needs the namespace adapter from Bun oven-sh#106. Native baseline and candidate both include that adapter because current engine main requires its API. This PR does not publish artifacts or change the artifact recipe; batch publication stays with the coordinator.

Keep call, construct, property-read and async-resume stack positions separate
from exception expression ranges. Preserve exact instruction and resume-label
mappings through bytecode rewriting, optimization and owned cache decoding.

Extend the prior native-qualified call-position implementation with property
lexer tokens and Node 24 regressions for builtin constructors and returning
arrows. Keep proper-tail-call behavior unchanged; the paired Bun adapter
preserves constructor syntax and invalidates its runtime transpiler cache.

The paired integration builds on robobun's upstream source-position work in
oven-sh/bun#35179, oven-sh/bun#37396, and oven-sh/bun#41580. Publication stays
with the OpenClaw artifact coordinator.
@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@steipete
steipete marked this pull request as ready for review October 4, 2026 22:51
@steipete
steipete merged commit e9d324a into openclaw/main Oct 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant