Repository navigation
test(ci): qualify Bun's Darwin watcher repair - #54
Merged
vincentkoc merged 3 commits intoNov 12, 2026
Merged
Conversation
This was referenced Nov 12, 2026
vincentkoc
marked this pull request as ready for review
November 12, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full shipping run compiled all 21 engine archives and passed Linux and Windows qualification, but native Darwin Bun compilation failed before runtime tests: the fork watcher retained an unconditional
Fdimport and a call to the now-privateEventLoopCtx::platform_event_loop().Select signed Bun repair
dd694cf4c8226ffb24821b6184b1c15ac36c76b7, treeb60f7b8898514913a8125bef65707996fcd88bff. That repair scopes the import and uses the existing public loop accessor without widening the I/O API. Its parent also preserves the restored compiled external-ESM SDK-alias regression.The final PR diff changes only the candidate commit/tree and matching adapter pin: two JSON files, three values. Engine source, archive recipes, frozen baseline, manifest blob, adapter contents, test selection and assertions are unchanged. The temporary replay workflow is absent from the final diff; the canonical shipping workflow is restored byte-for-byte.
Validation:
git diff --checkpass. Fresh review of both the Bun repair and this final pin update found no actionable P0–P2 findings.1781f94dc026dc409d2eb8d03b27c7e5d8a3c370. Linux builds/qualifies exact Bundd694cf4c8: 85 sync files / 87 passing rows / zero regressions, plus 44 comparison files / 46 passing candidate rows. The unchangedcandidate-pass-baseline-observed-v1policy retains two unreported historical baseline files (HTTP and Intl);baseline_all_passedandall_passedremain false. AOT and compile-cache gates pass. ARM64's 1,901 stress and 1,639 module rows all pass, including typed-array and namespace/module native cases; Windows startup/DFG/FFI/accounting gates pass. Report identities, raw rows and report-only ZIP digests were independently checked.13944592998/d8bd1ebca086c3b18fbdeff8099b07732ec8de0e2f00c05148d6a8239cb551c4; ARM6413946565723/d2a05db5e29d05a843091016de7ba50e688a703b033ef278acfef8c06a72d59f; Windows13942504762/45633ed4ac623c8c2e727d5d35d2bfa613d30e26494fd9ebef67c1eeb8de1324.bcb792d40469dbcfbca2f57f637de0ba6f7097cawith earlier Buna03e7c861f. Darwin compilation fails; assembly is skipped. This is prior-candidate evidence.dd694cf4c8and the verified retained ARM64 engine archive from that source/run: 53 selected files / 55 passing ledger rows, including all four watcher suites, and four standalone AOT checks. Independent report verification binds the candidate tree, engine, controller, unchanged selection, exact three-value overlay, invocation/result hashes and raw outcomes. Report artifact13948171041, ZIP SHA-256cc5e50146b3e839fd1423a53c21034eda8f9df0c7998d265840d85a474fac266; binary SHA-256b2518afd9e5789ed30c3cdfcbef48f4f3fc7c5e00c2849d15948652a7e4114df. This diagnostic replay uses a retained archive and explicitly does not claim shipping admission.The repaired native Darwin replay and all five current-head native checks are green. This PR merged as signed
de72d14dc8d937924f15514c5f0d86ae87631052, retaining both parents and the exact reviewed tree. Full shipping dry run 43236817413 passed all 21 archive builds, preflight, Linux/Darwin/Windows qualification and checksum assembly: 26 successful jobs, publication skipped. Root independently verified report identities and raw outcomes. Documentation-only PR 55 subsequently merged as signed3357f9d63e6dd87a53f2aade723482130a55c0cd, correcting stale release text without changing machine inputs, recipes or engine code. The prospective publication source must produce its own artifacts and all 26 green gates through the nativepublish=trueworkflow before authorization. Publication and consumer pins remain unchanged.Use a merge commit to preserve the signed qualification series. Bun tracking PR 221 records the broader integration and remaining release/consumer work.