Repository navigation
Closed
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Description
Summary
PATCH /api/channels/<id> with archived: true does not stop delivery: the channel remains addressable and messages still post. A recreated channel gets a new id; the old id returns 400. There is no unarchive or recreate endpoint.
Impact
A retired room can still receive traffic; after a purge and recreate, every stored id is stale. A future mention may wake nothing if the client filters archived channels, and old links fail.
Expected
- Archived channels reject new messages, or return a clear error.
- Document the archive semantics and id rotation.
- Add an unarchive or explicit recreate endpoint, or make the behaviour explicit.
Steps to reproduce
- Archive a channel.
- Post to it: the message is accepted.
- Delete and recreate the room: the new id differs; the old id answers 400.
Reacted by clawsweeper
Metadata
Metadata
Assignees
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Type
Fields
Priority
None yet
Activity
clawsweeper commentedon Nov 9, 2026
Codex review: this still needs some work.
Summary
Keep open: current main still permits archived-channel posting, and the author's open fixing PR must be resolved before this issue can close.
Reproducibility: Current source proves that authorized members can post after archival in both stores; no live reproduction ran, and the claimed absence of unarchive support is contradicted by source and tests.
Maintainer decision needed
Next step
Resolve the archive contract in #326 and use the existing Restore channel action for identity-preserving recovery.
Review details
Best possible solution:
Define archive write semantics and complete the existing PR within that contract while preserving history, links, and restoration.
Do we have a high-confidence way to reproduce the issue?
Current source proves that authorized members can post after archival in both stores; no live reproduction ran, and the claimed absence of unarchive support is contradicted by source and tests.
Is this the best way to solve the issue?
The shared posting guard is a focused implementation point after an archive contract is agreed, but restoration already solves recovery without recreation or ID rotation.
AGENTS.md: found and applied where relevant.
Remaining risk / open question:
Codex review notes: model internal, reasoning medium; reviewed against 03e85d6c704a.
Label changes
Label changes:
No label changes.
Label justifications:
P2: Archive lifecycle expectations affect a limited workflow without evidence of an urgent regression.impact:ux-friction: Unclear archive write semantics cause confusion, while identity-preserving recovery already exists in the product.Evidence reviewed
What I checked:
apps/api/internal/store/postgres/moderation.go:150, 03e85d6c704a)apps/api/internal/store/sqlite/sqlite.go:722, 03e85d6c704a)docs/features/workspaces.md:90, 03e85d6c704a)tests/e2e/channel-settings.spec.ts:27, 03e85d6c704a)docs/features/workspaces.md:107, 48d14b87d6d7)How this review workflow works
@clawsweeper re-reviewcomments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.@clawsweeper re-reviewor@clawsweeper re-runon an open PR or issue to request a fresh review only.@clawsweeper reviewto request a fresh review only.@clawsweeper explainto ask for more context, or@clawsweeper stopto stop active automation.Reviewed November 11, 2026, 6:19 AM ET / 11:19 UTC.
tre1d commentedon Nov 9, 2026
Code check:
CreateMessagecallsrequireCanPostTx, which checks workspace role, moderation, guest access, and the guest post budget, but never readsarchived_at. The sqlite store has the same shape. A guard inrequireCanPostTx(orCreateMessage) that rejects posts to archived channels, with tests in both stores, is a small fix. The recreate/unarchive endpoint is a separate feature.steipete commentedon Nov 14, 2026
Fixed by #326. The regression reproduced a new post to an archived channel returning HTTP 201; it now returns HTTP 409. Both stores also reject new thread replies, and the tests verify that PATCH with archived:false restores posting while retaining the same channel ID. Existing history remains readable, and the archive/restore semantics are documented.
The full project gate, focused store/HTTP regressions, and exact-head CI (including PostgreSQL, browser, Docker, desktop, and CodeQL checks) passed: https://github.com/openclaw/clickclack/actions/runs/43571876167.
fix(api): reject posts to archived channels (openclaw#326)