Skip to content

build(deps): refresh web desktop and database dependencies - #316

Merged
steipete merged 3 commits into
mainfrom
build/s23-clickclack-deps-20261104
Nov 5, 2026
Merged

steipete merged 3 commits into
mainfrom
build/s23-clickclack-deps-20261104

Conversation

@steipete

@steipete steipete commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Refresh eligible web, desktop, database, and development dependencies and rebuild the embedded web application.

User Impact

Update Electron within the supported 43 line, refresh web rendering and tooling patches, and update pgx and SQLite. Preserve the Node and Go floors, the 48-hour release-age policy, all security overrides, and SQLite's required libc pairing.

Why This Change Was Made

Select releases that have cleared the cooldown. Electron 45 and the protocol generator's TypeScript major remain outside this update; the current generator has a TypeScript 5 peer contract. The embedded bundle is regenerated from the selected dependencies.

Evidence

The full Linux gate, SQLite runtime pairing check, Go vulnerability scan, and production web/SDK build pass. Local lint and formatting checks pass. Dependency and generated-asset changes receive independent review through P2; PR CI supplies platform, database, and browser coverage.

Review surfaced a pre-existing PDF.js PostScript conditional-expression cache bug. A synthetic function produced identical results in the baseline 6.4.299 and updated 6.5.438 bundles (compiled result 0.2 versus interpreter result 0.2625 for input 0.25). This is not introduced by the update; generated vendor code is left unchanged.

Virtua remains at 0.53.6. Updating to 0.54.1 failed four existing browser scenarios covering activity scroll anchoring and history restoration; reverting only Virtua made all four pass on the AWS test lease. The remaining 432 browser tests passed on the first CI run.

CodeQL alert 18 in the generated PDF.js bundle was reviewed and dismissed as a false positive: it is intentional filename separator normalization followed by basename extraction, identical in the previous dependency version; the app has no attachment filename filesystem sink.

@steipete
steipete requested a review from a team as a code owner November 5, 2026 06:54
@clawsweeper

clawsweeper Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T07:16:35.133744Z 8f1b811 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 5, 2026
@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR updates web, Electron, database, and development dependencies and regenerates the embedded web application.

Example: A user opens the PDF artifact viewer.

  • Before: The embedded application loads PDF.js 6.4.299.
  • After: The embedded application loads PDF.js 6.5.438 and its matching worker.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Focused maintenance with substantial passing validation and no actionable finding, but browser validation remains unresolved.
Proof confidence 🦐 gold shrimp (3/6) The supplied maintainer-authored classification exempts ordinary contributor proof; the body records build and validation results rather than a live demonstration.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: The shipped application remains on older web, desktop, and database dependency releases.
Reason: The supplied maintainer-authored classification establishes direction, and the refresh preserves the existing runtime and security contracts.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: the maintainer-directed dependency refresh is absent from current main, and no discrete introduced defect was found; the failed Playwright check remains unattributed.

Priority: P3
Reviewed head: 091f704f225c0aa481cf630c2aaf0a001749972f

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: The existing Playwright run failed, and inaccessible logs prevent identifying which browser scenarios failed.
Agent review details

How this fits together

Package manifests and lockfiles select the web and desktop runtimes, while Go modules select database drivers; the built web application is embedded in the Go server and delivered to browsers.

flowchart LR
  A[Dependency manifests] --> B[Web build]
  B --> C[Embedded web assets]
  C --> D[Go server]
  D --> E[Browser application]
  A --> F[Electron desktop]
  G[Go modules] --> D
  D --> H[Database drivers]
Loading

Technical review

Best possible solution:

Land the focused dependency refresh once the failed browser check is classified and any demonstrated regression is repaired.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance rather than a bug report, and no target code was executed during this read-only review.

Is this the best way to solve the issue?

Updating the existing manifests and lockfiles and regenerating assets through the established build owner is appropriately scoped.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 66bdc67d6eb6.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned dependency changes: The introduced changes update existing dependencies without changing application source, schemas, runtime floors, security overrides, or install scripts. (apps/web/package.json:25, 091f704f225c)
  • Current main still needs the update: Current main retains the baseline dependency selections; its changes since the pinned base do not implement this refresh. (go.mod:11, 66bdc67d6eb6)
  • Existing runtime-hardening contract: The rationale in fix: secure runtimes and keep cancelled threads closed #308 establishes the Workerd security pin, framework upgrades, and paired SQLite/libc selection; this PR retains those boundaries. (pnpm-workspace.yaml:6, 541ce93c69e1)
  • Exact-head validation: Go, SQLite runtime pairing, vulnerability scanning, TypeScript, repeatable embedded builds, Node 24 compatibility, Docker, and desktop checks passed; Playwright failed during Run e2e tests. (.github/workflows/ci.yml:128, 091f704f225c)
  • Browser failure cannot yet be attributed: Annotations report only exit code 1, and retrieving the job log redirects to a blocked artifact host; neither a patch defect nor an unrelated failure is established. (091f704f225c)
  • Generated asset inspection: A read-only comparison found no new URL literals or newly unresolved literal local asset references in changed assets; exact-head CI also verified that regenerating the embedded application produces no differences. (apps/api/internal/webassets/dist/index.html:108, 091f704f225c)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: Routine dependency maintenance with no demonstrated urgent user-facing regression.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine dependency maintenance with no demonstrated urgent user-facing regression.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Inspect the failed Playwright job's logs or artifacts and determine whether the dependency refresh caused the failure.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 5, 2026, 2:09 AM ET / 07:09 UTC.

@steipete
steipete merged commit f7e3ad1 into main Nov 5, 2026
14 of 15 checks passed
@steipete
steipete deleted the build/s23-clickclack-deps-20261104 branch November 5, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant