Skip to content

fix(web): navigate reliably from push notifications - #328

Merged
steipete merged 8 commits into
mainfrom
fix/round20-push
Nov 14, 2026
Merged

steipete merged 8 commits into
mainfrom
fix/round20-push

Conversation

@steipete

Copy link
Copy Markdown
Contributor

A notification tap could resume the previous channel when an existing app window missed the worker message. Request an acknowledgement from a ready app and fall back to URL navigation when it cannot respond; responsive apps keep their current document and unsent state. Thread-reply notifications now target the thread root, which the route resolver can canonicalize lazily.

Both failures were reproduced before the fix: the browser remained in the old channel with its message listener unavailable, and the server generated a channel URL for a thread reply. The fixed API regressions and all 22 notification browser tests pass, including a check that responsive navigation does not reload the document. Web/root typechecks pass, embedded assets were rebuilt, and independent Codex P0–P2 review is clean. The captures use synthetic test accounts; physical iOS push delivery was not exercised.

Fixes #315.

Before: notification leaves the app in the previous channel

After: notification opens the requested channel

@steipete
steipete requested a review from a team as a code owner November 14, 2026 08:04
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T08:05:20.902928Z 8438db5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete
steipete merged commit 881f922 into main Nov 14, 2026
14 checks passed
@steipete
steipete deleted the fix/round20-push branch November 14, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Web push notifications don't link to the channel or thread

2 participants