Repository navigation
fix(web): navigate reliably from push notifications - #328
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A notification tap could resume the previous channel when an existing app window missed the worker message. Request an acknowledgement from a ready app and fall back to URL navigation when it cannot respond; responsive apps keep their current document and unsent state. Thread-reply notifications now target the thread root, which the route resolver can canonicalize lazily.
Both failures were reproduced before the fix: the browser remained in the old channel with its message listener unavailable, and the server generated a channel URL for a thread reply. The fixed API regressions and all 22 notification browser tests pass, including a check that responsive navigation does not reload the document. Web/root typechecks pass, embedded assets were rebuilt, and independent Codex P0–P2 review is clean. The captures use synthetic test accounts; physical iOS push delivery was not exercised.
Fixes #315.