Repository navigation
fix(web): name the one-time signing secret field for screen readers - #333
KrasimirKralev wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR associates each revealed signing-secret field with its visible label in both integration panels and updates browser coverage and embedded assets. Example: A workspace owner rotates the secret for /deploy in Settings → Integrations.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR fixes an accessibility defect still present on main, with no actionable correctness or security findings. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe integration settings panels receive command and subscription records, reveal secrets returned by create or rotate requests, and render fields with Copy and Done controls. flowchart LR
A[Workspace owner] --> B[Integration settings]
B --> C[Secret rotation API]
C --> D[Per-row revealed secret]
D --> E[Labeled readonly field]
E --> F[Browser accessibility tree]
Technical reviewBest possible solution: Land the native label associations and per-record IDs with the existing browser regression coverage and rebuilt embedded assets. Do we have a high-confidence way to reproduce the issue? Current-main markup confirms the missing association in both panels, and the contributor supplies matching before/after browser accessibility output; no target code was run during this read-only review. Is this the best way to solve the issue? The patch directly repairs the semantic association using existing panel owners and native HTML, with distinct prefixes and record IDs preventing cross-row label collisions. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 38d16cff5204. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 19, 2026, 2:33 AM ET / 07:33 UTC. |
Fix archived channel and thread composers, including embeds, and name one-time integration signing-secret fields for screen readers. Includes the verified contribution from #333 and retains @KrasimirKralev's work and credit. Refresh compatible web, desktop, tooling, and Go dependencies while preserving runtime minimums, security overrides, Virtua 0.54.0, and the matched SQLite/libc pair. Make the writable-mode fixture independent of the process umask. Proof: three failing-before browser regressions; 19 passing affected Playwright tests; 98 web tests, Go packages with a focused rerun after the fixture fix, 31 FakeCo tests, 69 desktop tests; typechecks, lint/format, repeated embedded builds, docs site, and clean govulncheck. Final independent P0–P2 review is clean. Co-authored-by: Krasimir Kralev <263465593+KrasimirKralev@users.noreply.github.com>
|
Included in #330, with your contributor credit preserved. The combined change passes all 19 affected browser tests, the full PR CI matrix, and independent P0–P2 review. Thank you for making the one-time signing-secret fields identifiable to screen-reader users. |
Maintainer edits
MUST: Keep Allow edits from maintainers enabled for this PR so maintainers
can help update the branch when needed.
What Problem This Solves
Fixes: screen-reader users hear an unnamed, read-only text field when they rotate a slash command or event subscription secret in workspace settings, so they cannot tell that the field holds the one-time signing secret they must copy now.
textboxwith no name, in both the Slash commands and the Event subscriptions panels.User Impact
User impact: when an owner rotates a signing secret, screen readers announce the field as "Signing secret — visible once", the same words sighted users see, so they know what to copy before dismissing it. Nothing changes visually.
Why This Change Was Made
The caption becomes a
<label>tied to its field, following the bot token reveal in the same settings area. Both panels can show several revealed secrets at once (one per row), so each field gets a per-row id (slash-command-secret-<id>,event-subscription-secret-<id>) and each label names only its own row's field.The existing e2e test
keeps each registration busy until its own secret rotation finishesalready reveals two secrets in each panel at the same time. It now also checks, for every revealed row, that the textbox named "Signing secret — visible once" holds that row's own secret. On upstream38d16cffit fails withelement(s) not found; with this changetests/e2e/integrations.spec.tspasses 11/11, and the changed test passes 3/3 repeats.apps/api/internal/webassets/distis rebuilt withpnpm build; a second build leaves no diff. OneCHANGELOG.mdline.Evidence
webServer(pnpm build+go run ./apps/api/cmd/clickclack serve --dev-bootstrap=true, freshdata/e2e), headless Google Chrome. Before = upstream38d16cffweb sources, after = this branch.locator.ariaSnapshot()), with the secret value replaced by<secret redacted>.