Skip to content

fix(web): name the one-time signing secret field for screen readers - #333

Closed
KrasimirKralev wants to merge 1 commit into
openclaw:mainfrom
KrasimirKralev:improve/integration-secret-labels
Closed

KrasimirKralev wants to merge 1 commit into
openclaw:mainfrom
KrasimirKralev:improve/integration-secret-labels

Conversation

@KrasimirKralev

Copy link
Copy Markdown
Contributor
Maintainer edits

MUST: Keep Allow edits from maintainers enabled for this PR so maintainers
can help update the branch when needed.

What Problem This Solves

Fixes: screen-reader users hear an unnamed, read-only text field when they rotate a slash command or event subscription secret in workspace settings, so they cannot tell that the field holds the one-time signing secret they must copy now.

  • Problem: after Rotate secret under Settings → Integrations, the secret appears under a visible "Signing secret — visible once" caption, but that caption is plain text with no link to the field. Chrome's accessibility tree shows the field as textbox with no name, in both the Slash commands and the Event subscriptions panels.
  • What did NOT change (scope boundary): the caption text, its styling, the Copy and Done buttons, and every API call are unchanged. The bot token reveal already labels its field this way and is not touched.
  • Requested by a maintainer/owner? No. Found while checking the settings pages for unnamed form fields.

User Impact

User impact: when an owner rotates a signing secret, screen readers announce the field as "Signing secret — visible once", the same words sighted users see, so they know what to copy before dismissing it. Nothing changes visually.

Why This Change Was Made

The caption becomes a <label> tied to its field, following the bot token reveal in the same settings area. Both panels can show several revealed secrets at once (one per row), so each field gets a per-row id (slash-command-secret-<id>, event-subscription-secret-<id>) and each label names only its own row's field.

The existing e2e test keeps each registration busy until its own secret rotation finishes already reveals two secrets in each panel at the same time. It now also checks, for every revealed row, that the textbox named "Signing secret — visible once" holds that row's own secret. On upstream 38d16cff it fails with element(s) not found; with this change tests/e2e/integrations.spec.ts passes 11/11, and the changed test passes 3/3 repeats. apps/api/internal/webassets/dist is rebuilt with pnpm build; a second build leaves no diff. One CHANGELOG.md line.

Evidence

  • Behavior or issue addressed: the accessible name of the revealed signing-secret field after rotating a slash command or event subscription secret.
  • Real environment tested: Linux, Go 1.27.1, the real server from this repo's Playwright webServer (pnpm build + go run ./apps/api/cmd/clickclack serve --dev-bootstrap=true, fresh data/e2e), headless Google Chrome. Before = upstream 38d16cff web sources, after = this branch.
  • Exact steps or command run after this patch: a throwaway Playwright spec (not committed) creates a workspace, a bot, a custom app installation, one slash command and one event subscription through the API, opens Settings → Integrations → the app, clicks Rotate secret in each panel, and prints Chrome's accessibility snapshot of the revealed secret block (locator.ariaSnapshot()), with the secret value replaced by <secret redacted>.
  • Evidence after fix:
# before (upstream 38d16cff)
## Slash commands
- text: Signing secret — visible once
- textbox: <secret redacted>
- button "Copy"
- button "Done"
getByRole("textbox", { name: "Signing secret — visible once" }) matches: 0

## Event subscriptions
- text: Signing secret — visible once
- textbox: <secret redacted>
- button "Copy"
- button "Done"
getByRole("textbox", { name: "Signing secret — visible once" }) matches: 0

# after (this branch)
## Slash commands
- text: Signing secret — visible once
- textbox "Signing secret — visible once": <secret redacted>
- button "Copy"
- button "Done"
getByRole("textbox", { name: "Signing secret — visible once" }) matches: 1

## Event subscriptions
- text: Signing secret — visible once
- textbox "Signing secret — visible once": <secret redacted>
- button "Copy"
- button "Done"
getByRole("textbox", { name: "Signing secret — visible once" }) matches: 1
  • Observed result after fix: in the real app in Chrome, the revealed secret field in both panels now has the accessible name "Signing secret — visible once"; before, it had none.
  • What was not tested: a real screen reader (NVDA, VoiceOver, Orca); the desktop app shell.
  • Proof limitations or environment constraints: the accessibility tree is Chrome's, read through Playwright; no visual change, so no screenshots.

@KrasimirKralev
KrasimirKralev requested a review from a team as a code owner November 19, 2026 07:20
@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. labels Nov 19, 2026
@clawsweeper

clawsweeper Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR associates each revealed signing-secret field with its visible label in both integration panels and updates browser coverage and embedded assets.

Example: A workspace owner rotates the secret for /deploy in Settings → Integrations.

  • Before: Chrome exposes an unnamed textbox beneath “Signing secret — visible once”.
  • After: Chrome exposes the textbox with the accessible name “Signing secret — visible once”.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A focused accessibility repair with relevant browser output, useful regression assertions, consistent embedded assets, and successful head checks.
Proof confidence 🦞 diamond lobster (5/6) Sufficient (live_output): Redacted Chrome accessibility output exercises both rotation flows through the running Go server and real settings UI, showing named textboxes after the fix; actual screen-reader and desktop-shell testing are explicitly outside the supplied proof.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Screen-reader users encounter unnamed textboxes when identifying revealed integration signing secrets.
Reason: Associating existing captions with their fields restores expected accessibility without introducing a setting, API, or behavior policy.

Merge readiness

✅ Ready for maintainer review

Keep open: this PR fixes an accessibility defect still present on main, with no actionable correctness or security findings.

Priority: P2
Reviewed head: 44243c1e591bc2d0b70fca283e8b894affe54054

Before merge

None.

Findings

None.

Agent review details

How this fits together

The integration settings panels receive command and subscription records, reveal secrets returned by create or rotate requests, and render fields with Copy and Done controls.

flowchart LR
  A[Workspace owner] --> B[Integration settings]
  B --> C[Secret rotation API]
  C --> D[Per-row revealed secret]
  D --> E[Labeled readonly field]
  E --> F[Browser accessibility tree]
Loading

Technical review

Best possible solution:

Land the native label associations and per-record IDs with the existing browser regression coverage and rebuilt embedded assets.

Do we have a high-confidence way to reproduce the issue?

Current-main markup confirms the missing association in both panels, and the contributor supplies matching before/after browser accessibility output; no target code was run during this read-only review.

Is this the best way to solve the issue?

The patch directly repairs the semantic association using existing panel owners and native HTML, with distinct prefixes and record IDs preventing cross-row label collisions.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 38d16cff5204.

Provenance checked

  • Signing-secret reveal markup keeps the original intent (feat: add reusable workspace integrations #79: The original integration feature added per-registration signing secrets, rotation, and independent mutation handling.)
  • Embedded web assets keeps the original intent (55b55d4: The prior dependency refresh rebuilt the shipped web assets; this PR updates those generated assets for its source repair.)
  • Integration browser coverage keeps the original intent (5a4bf95: Existing coverage verifies independent secret mutations; added accessibility assertions reuse its simultaneous reveal scenario.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

  • Exact source change and current-main defect: Both main-branch panels use an unrelated span above the secret input; the introduced diff replaces it with a label and matching per-record input ID, without changing requests or secret lifecycle. (apps/web/src/components/settings/integrations/SlashCommandsPanel.svelte:248, 44243c1e591b)
  • Real browser accessibility evidence: The full PR body supplies redacted before/after Chrome accessibility output from the running Go server and integration settings flow: both rotated-secret textboxes change from unnamed to the intended name, with role-query matches changing from zero to one. Body identity: 660038e3576a112af6b1eeab2c020a7007231fabdbb0179020948b57483a24eb. (44243c1e591b)
  • Existing accessible reveal pattern: The bot token reveal already associates a native label with its readonly text input, supporting this narrowly scoped repair. (apps/web/src/components/settings/bots/TokenRevealPanel.svelte:269, 44243c1e591b)
  • Regression coverage: The existing real-API rotation scenario now checks accessible names and row-specific secret values with two revealed rows in each panel; the body reports failure on the base and success on the head. (tests/e2e/integrations.spec.ts:18, 44243c1e591b)
  • Generated asset inspection: The compiled settings module contains the corresponding label templates and matching for/id updates; remaining changes are compiler identifier shifts and updated asset references. (apps/api/internal/webassets/dist/_app/immutable/nodes/8.C2QbjXJE.js, 44243c1e591b)
  • Feature history and original intent: Panel creation, mutation isolation, and later integration tests consistently point to shakkernerd; the original feature PR describes reusable installations and independent secret mutations, which this repair preserves. Following history encounters an unavailable parent blob at file creation; available creation commits and GitHub attribution establish ownership. (apps/web/src/components/settings/integrations/SlashCommandsPanel.svelte:248, 38d16cff5204)

Likely related people:

  • Shakker: Raw commit e5e8857 adds apps/web/src/components/settings/integrations/SlashCommandsPanel.svelte:234 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: e5e88574b5b1; files: apps/web/src/components/settings/integrations/SlashCommandsPanel.svelte)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P2: The missing accessible names impair identification of one-time signing-secret fields in a limited integration administration workflow.
  • add proof: sufficient: Contributor real behavior proof is sufficient.
  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: The missing accessible names impair identification of one-time signing-secret fields in a limited integration administration workflow.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 19, 2026, 2:33 AM ET / 07:33 UTC.

steipete pushed a commit that referenced this pull request Nov 21, 2026
Fix archived channel and thread composers, including embeds, and name one-time integration signing-secret fields for screen readers. Includes the verified contribution from #333 and retains @KrasimirKralev's work and credit.

Refresh compatible web, desktop, tooling, and Go dependencies while preserving runtime minimums, security overrides, Virtua 0.54.0, and the matched SQLite/libc pair. Make the writable-mode fixture independent of the process umask.

Proof: three failing-before browser regressions; 19 passing affected Playwright tests; 98 web tests, Go packages with a focused rerun after the fixture fix, 31 FakeCo tests, 69 desktop tests; typechecks, lint/format, repeated embedded builds, docs site, and clean govulncheck. Final independent P0–P2 review is clean.

Co-authored-by: Krasimir Kralev <263465593+KrasimirKralev@users.noreply.github.com>
@steipete

Copy link
Copy Markdown
Contributor

Included in #330, with your contributor credit preserved. The combined change passes all 19 affected browser tests, the full PR CI matrix, and independent P0–P2 review. Thank you for making the one-time signing-secret fields identifiable to screen-reader users.

@steipete steipete closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants