Skip to content

fix(security): build with patched Go 1.27.3 toolchain - #156

Merged
steipete merged 2 commits into
mainfrom
security/go1273
Oct 21, 2026
Merged

steipete merged 2 commits into
mainfrom
security/go1273

Conversation

@steipete

@steipete steipete commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Select Go 1.27.3 for source, CI, release builds, and release snapshots while retaining the Go 1.26 language minimum. Prepare the v0.4.1 changelog and keep the next Unreleased section empty.

The native macOS Go 1.27.2 baseline reaches GO-2026-6809 through rfbclient.New at internal/rfbclient/backend.go:49, then io.ReadFull and x509.Certificate.Verify. The same symbol-level govulncheck ./... scan is clean with Go 1.27.3.

Validation: go build ./..., pnpm check, pnpm test (223 tests), and pnpm test:native pass, including Go race tests/vet, the vendored Swift library, native macOS suites, and loopback transport coverage. Independent P0–P3 autoreview found no actionable issues.

Only release artifacts are in scope; no service deployment or restart is authorized or performed.

Both CLI and CodeQL setup steps also set Go 1.27.3 explicitly: setup-go otherwise reads the older language minimum from go-version-file before the toolchain suggestion. The workflow contract test checks the explicit patched version.

@steipete
steipete requested a review from a team as a code owner October 21, 2026 03:25
@clawsweeper

clawsweeper Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T03:47:17.661718Z 5af87f8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 21, 2026
@clawsweeper

clawsweeper Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Select Go 1.27.3 for source and release builds, document the compiler selection, and prepare the v0.4.1 changelog.

Example: Build crabfleet-connect using the repository-selected Go toolchain.

  • Before: Main selects Go 1.27.2, which the Go vulnerability database lists as affected by GO-2026-6809.
  • After: This PR selects Go 1.27.3, which includes the advisory's certificate-validation fix.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, advisory-backed update with passing relevant build and test checks and no identified defect; Swift analysis is still pending.
Proof confidence 🌊 off-meta tidepool Not applicable: The supplied maintainer-authored classification exempts ordinary contributor proof; inspected CI supports build compatibility, while no certificate-rejection demonstration or native macOS validation was independently run.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Connector binaries built with the selected compiler retain the affected certificate-validation implementation.
Reason: The advisory supports the compiler update, and the supplied maintainer-authored classification establishes direction for this focused repair and release preparation.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it is a focused, maintainer-directed security update that current main does not contain, with no actionable patch defects found.

Priority: P2
Reviewed head: c48e390e9c76d9ae3198c30c92a2d9a186d7b351

Before merge

None.

Findings

None.

Agent review details

How this fits together

The Go module selects the connector compiler, CI consumes that selection, and the release workflow independently pins the compiler used to produce downloadable Linux archives.

flowchart LR
  A[Go module] --> B[Source builds]
  A --> C[Connector CI]
  D[Release workflow] --> E[GoReleaser]
  E --> F[Linux connector archives]
Loading

Technical review

Best possible solution:

Use the existing compiler-selection paths to ship the patched connector through the normal release process.

Do we have a high-confidence way to reproduce the issue?

Main's Go 1.27.2 selection falls within the authoritative advisory's affected range; no exploit or govulncheck run was performed during this read-only review.

Is this the best way to solve the issue?

Updating the existing module selection and both release pins is the smallest complete compiler repair, preserving the Go 1.26 language minimum and historical-tag rebuild protection.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 9e54b00cfc90.

Provenance checked

  • Module and release compiler selection keeps the original intent (6e562bf: Select a patched compiler while retaining the source minimum and protecting rebuilds of historical release tags.)
  • Documented source-build minimum keeps the original intent (d1905a5: Require Go 1.26 for source builds while selecting a newer preferred compiler, as recorded in build(deps): refresh desktop tooling and media dependencies #147.)
  • Changelog release preparation keeps the original intent (c00eb5b: Prepare a versioned changelog section for release-note extraction while retaining an empty Unreleased heading.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

What I checked:

  • Verified introduced changes: The pinned diff changes three existing compiler selections from Go 1.27.2 to 1.27.3, updates the README, and prepares release notes without changing application logic. (go.mod:5, c48e390e9c76)
  • Current main still needs the update: The default branch remains at the pinned base, whose module and both release jobs select Go 1.27.2; the latest published release remains v0.4.0. (go.mod:5, 9e54b00cfc90)
  • Authoritative advisory: The Go standard library compiled into the connector is the relevant dependency: GO-2026-6809 identifies crypto/x509.Certificate.Verify and lists Go 1.27.3 as fixed. The advisory describes distrust of compromised intermediate certificates. (data/osv/GO-2026-6809.json, e0bad56276e9)
  • Existing compiler ownership preserved: Connector CI and Go CodeQL already read go.mod; release and snapshot jobs retain their explicit pins. The prior rationale in ci: move native macOS tests to Xcode 27 #155 was to prevent historical-tag rebuilds from selecting vulnerable compilers, and this PR preserves that design. (.github/workflows/release.yml:97, 6e562bf7b0b2)
  • Exact-head validation: GitHub reports passing connector race tests, vet, Linux and Windows builds, Linux desktop/media checks, Worker checks, and browser tests for the reviewed head. Swift CodeQL remains in progress; these results do not independently verify the body’s native macOS or vulnerability-scan claims. (.github/workflows/cli.yml:47, c48e390e9c76)
  • Policy and ownership history: The full root policy was read; no nested policy, maintainer notes, or pr-simplify skill governs these changes. History identifies steipete as the recent compiler and release owner, with earlier release hardening by Vincent Koc; follow-history inspection stops at unavailable older blobs, leaving earliest ownership unasserted. (AGENTS.md, 9e54b00cfc90)

Labels

Label changes:

  • add P2: This addresses a confirmed standard-library security advisory through a narrow compiler patch update; no active exploitation or urgent user outage is established.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: This addresses a confirmed standard-library security advisory through a narrow compiler patch update; no active exploitation or urgent user outage is established.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 20, 2026, 11:38 PM ET / October 21, 2026, 03:38 UTC.

@steipete
steipete merged commit 8f1e8a8 into main Oct 21, 2026
9 of 10 checks passed
@steipete
steipete deleted the security/go1273 branch October 21, 2026 04:04
@steipete

Copy link
Copy Markdown
Contributor Author

Merged with all exact-head checks green. GO-2026-6809 was reachable before the toolchain update; the post-update scan is clean.

Released v0.4.1 after the release dry run. The release pipeline passed. The fleet-signed tag verifies locally and on GitHub; both downloaded Linux archives match checksums, report Go 1.27.3 and version 0.4.1, and the release notes match the tagged changelog. The Go proxy resolves the tag to the merged source. There is no Homebrew or macOS asset channel for this connector release. No Worker service deployment was triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant