Repository navigation
fix(security): build with patched Go 1.27.3 toolchain - #156
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesSelect Go 1.27.3 for source and release builds, document the compiler selection, and prepare the v0.4.1 changelog. Example: Build crabfleet-connect using the repository-selected Go toolchain.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it is a focused, maintainer-directed security update that current main does not contain, with no actionable patch defects found. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe Go module selects the connector compiler, CI consumes that selection, and the release workflow independently pins the compiler used to produce downloadable Linux archives. flowchart LR
A[Go module] --> B[Source builds]
A --> C[Connector CI]
D[Release workflow] --> E[GoReleaser]
E --> F[Linux connector archives]
Technical reviewBest possible solution: Use the existing compiler-selection paths to ship the patched connector through the normal release process. Do we have a high-confidence way to reproduce the issue? Main's Go 1.27.2 selection falls within the authoritative advisory's affected range; no exploit or govulncheck run was performed during this read-only review. Is this the best way to solve the issue? Updating the existing module selection and both release pins is the smallest complete compiler repair, preserving the Go 1.26 language minimum and historical-tag rebuild protection. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 9e54b00cfc90. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 20, 2026, 11:38 PM ET / October 21, 2026, 03:38 UTC. |
|
Merged with all exact-head checks green. GO-2026-6809 was reachable before the toolchain update; the post-update scan is clean. Released v0.4.1 after the release dry run. The release pipeline passed. The fleet-signed tag verifies locally and on GitHub; both downloaded Linux archives match checksums, report Go 1.27.3 and version 0.4.1, and the release notes match the tagged changelog. The Go proxy resolves the tag to the merged source. There is no Homebrew or macOS asset channel for this connector release. No Worker service deployment was triggered. |
Select Go 1.27.3 for source, CI, release builds, and release snapshots while retaining the Go 1.26 language minimum. Prepare the v0.4.1 changelog and keep the next Unreleased section empty.
The native macOS Go 1.27.2 baseline reaches GO-2026-6809 through
rfbclient.Newatinternal/rfbclient/backend.go:49, thenio.ReadFullandx509.Certificate.Verify. The same symbol-levelgovulncheck ./...scan is clean with Go 1.27.3.Validation:
go build ./...,pnpm check,pnpm test(223 tests), andpnpm test:nativepass, including Go race tests/vet, the vendored Swift library, native macOS suites, and loopback transport coverage. Independent P0–P3 autoreview found no actionable issues.Only release artifacts are in scope; no service deployment or restart is authorized or performed.
Both CLI and CodeQL setup steps also set Go 1.27.3 explicitly: setup-go otherwise reads the older language minimum from go-version-file before the toolchain suggestion. The workflow contract test checks the explicit patched version.