Skip to content

fix(ci): pin Node releases with incident key rejection - #158

Merged
joshavant merged 1 commit into
mainfrom
security/emudhra-node-release
Oct 22, 2026
Merged

joshavant merged 1 commit into
mainfrom
security/emudhra-node-release

Conversation

@joshavant

Copy link
Copy Markdown
Contributor

What Problem This Solves

Existing workflows can select an older Node 24 patch with compromised CA trust.

User Impact

CI and product-router build/deploy jobs select released Node 24.22.1. Existing deployments require the normal owner rollout.

Why This Change Was Made

Pin all six managed workflow runtimes to the qualified patch while preserving the current Node 24 and pnpm 11 contracts.

Evidence

Isolated Linux arm 64 pnpm check, pnpm test (223 passes) and pnpm test:native pass, including Go race tests and vet. Native macOS tests explicitly skip on Linux. Changed YAML, diff checks and independent P 0–P 2 full-workflow review pass. Main-push production Worker deployment is existing behavior; no deployment was performed during preparation. Future merges require separate permission.

@joshavant
joshavant requested a review from a team as a code owner October 21, 2026 22:17
@clawsweeper

clawsweeper Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 21, 2026
@clawsweeper

clawsweeper Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge.

What this changes

Pins six GitHub Actions workflow runtimes to Node 24.22.1.

Example: A runner caches Node 24.22.0 when a workflow starts.

  • Before: The Node 24 selector can accept the older cached runtime.
  • After: The workflow requires Node 24.22.1, which includes compromised-key rejection.

Review scores

Measure Result What it means
Overall readiness 🧂 unranked krab (1/6) The patch is minimal and has no code findings; missing evidence for the material TLS authorization change blocks readiness.
Proof confidence 🧂 unranked krab (1/6) Real behavior proof is necessary before merge. See Before merge.
Patch quality 🦐 gold shrimp (3/6) Security review found an item that needs attention.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Build and deployment jobs can use a Node runtime that trusts compromised certificate keys.
Reason: The maintainer-authored direction addresses a published upstream security defect with six selector changes and preserves existing runtime contracts.

Merge readiness

⛔ Blocked before merge - 3 items remain

Keep this PR open: the focused security update remains necessary on main, and no actionable code defect was found.

Priority: P2
Reviewed head: fd038182540c000d2588b2f5e9001e8886f9ec3c

Before merge

  • Add real behavior proof - Authority-chain proof required: deploy-worker selects Node 24.22.1, supplies the DNS secret, and executes scripts/ensure-cloudflare-domains.mjs, which sends a Bearer header using Node fetch. The supplied Linux validation narrative and inspected job metadata do not show a valid peer succeeding and a compromised-intermediate peer rejected before receiving that header through the real request owner. Provide redacted terminal output or logs for those scenarios; redact keys, IPs, account details, and non-public endpoints. No persisted authorization or reassignment behavior changes here. After adding proof, update the PR body, then request a new review with @clawsweeper re-review. The PR author or someone with repository write access can request it.
  • Resolve security review attention item - No concrete introduced vulnerability was found, but the changed TLS authorization boundary needs final-effect evidence.
  • Resolve merge risk - The selected runtime changes TLS peer authorization for authenticated deployment requests; rejection before credential transmission remains unestablished through the production request owner.

Findings

None.

Tests

  • Missing end-to-end proof: No supplied production-path trace shows a valid peer succeeding and a compromised-intermediate peer rejected before credential transmission under Node 24.22.1.
Agent review details

How this fits together

GitHub Actions selects Node before package installation, validation, publishing, and deployment; the selected runtime also executes authenticated Cloudflare requests.

flowchart LR
 Workflows[GitHub workflows] --> Setup[Node setup action]
 Setup --> Runtime[Node 24.22.1]
 Runtime --> Validation[Install and validation]
 Runtime --> Domains[Domain request helper]
 Domains --> TLS[TLS peer verification]
 TLS --> Cloudflare[Cloudflare API]
Loading

Technical review

Best possible solution:

Retain the six exact runtime pins and verify the authenticated Node request boundary before landing.

Do we have a high-confidence way to reproduce the issue?

Main's broad Node selectors and the setup action's cache matching establish how an older runtime can be selected; compromised-peer acceptance was not executed during this review.

Is this the best way to solve the issue?

Selecting the upstream patched runtime is the smallest complete workflow repair and preserves the existing Node major and pnpm contracts.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 31759069fa96.

Merge-risk options

Maintainer options:

  1. Verify the authenticated request boundary (recommended)
    Supply a production-path trace under Node 24.22.1 showing a valid TLS peer succeeds and a compromised-intermediate peer is rejected before receiving the request's credential header.

Provenance checked

  • Workflow Node runtime selection keeps the original intent (bd55723, a84c169, 14ea065, b853216, 2f3b0d4, c00eb5b: The workflows select Node 24 for their respective automation tasks; subsequent dependency maintenance explicitly retained that major-version contract.)

Testing

Proof path: none.

Security

Needs attention: No concrete introduced vulnerability was found, but the changed TLS authorization boundary needs final-effect evidence.

Evidence

What I checked:

  • Pinned change and production consumer: The introduced diff replaces six Node 24 selectors with 24.22.1 and changes no permissions, secrets, deployment commands, or persisted formats. Main remains at 3175906 with the broad selectors. The deployment workflow passes a repository secret to scripts/ensure-cloudflare-domains.mjs, whose request helper sends a Bearer header through Node fetch at lines 14–18. Root AGENTS.md applies; no nested policy, maintainer notes, or pr-simplify skill was found. The checkout remained clean. (.github/workflows/deploy-worker.yml:28, fd038182540c)
  • Published security fix: The official advisory identifies the eMudhra intermediate compromise and links Node 24.22.1. Its release record includes this commit, which adds compromised-SPKI rejection through Node's certificate verification hook. This dependency contract applies because the workflows execute the selected Node runtime. (01acf0ee7493)
  • Cached runtime selection: The exact action revision used by these workflows checks the tool cache against versionSpec and uses semver matching; an exact patch selector excludes older cached Node 24 releases. (src/distributions/base-distribution.ts, 820762786026)
  • Validation and inspection limits: Exact-head Worker job metadata reports successful Node setup, installation, checks, tests, browser tests, build, and package dry run; Rust validation also completed successfully. Swift analysis remained in progress. Job-log retrieval was blocked by the artifact host allowlist, so runtime output was not inspected. No local gates were run under the read-only review constraint. A broad history content search encountered unavailable objects; the scoped six-file history search succeeded. (.github/workflows/worker-ci.yml:28, fd038182540c)
  • History and related repair: Merged dependency maintenance explicitly preserves Node 24 and pnpm 11.27.1, which this PR retains. Merged Rust incident repair changes the Rust verifier and root data, leaving this Node workflow repair distinct. Feature history identifies Peter Steinberger across deployment and runtime maintenance, Vincent Koc in hydration and workflow hardening, and the security team in CODEOWNERS. (.github/CODEOWNERS:3, 31759069fa96)

Likely related people:

  • Peter Steinberger: Raw commit 615c65e adds .github/workflows/deploy-worker.yml:26 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 615c65e949b6; files: .github/workflows/deploy-worker.yml)
  • Vincent Koc: Raw commit 14ea065 adds .github/workflows/crabbox-hydrate.yml:30 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 14ea065aad4c; files: .github/workflows/crabbox-hydrate.yml)

Labels

Label changes:

  • add P2: This is a focused workflow security repair with no demonstrated repository compromise or current workflow outage.
  • add merge-risk: 🚨 security-boundary: The Node update changes certificate-chain authorization for runtime consumers that transmit Cloudflare credentials; successful validation jobs do not establish that final boundary.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Label justifications:

  • P2: This is a focused workflow security repair with no demonstrated repository compromise or current workflow outage.
  • merge-risk: 🚨 security-boundary: The Node update changes certificate-chain authorization for runtime consumers that transmit Cloudflare credentials; successful validation jobs do not establish that final boundary.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Add final-effect proof through the production Node request owner that a valid peer succeeds and a compromised-intermediate peer receives no credential header.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 21, 2026, 6:31 PM ET / 22:31 UTC.

@joshavant
joshavant merged commit 6e370a1 into main Oct 22, 2026
13 checks passed
@joshavant
joshavant deleted the security/emudhra-node-release branch October 22, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant