Repository navigation
fix(ci): pin Node releases with incident key rejection - #158
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesPins six GitHub Actions workflow runtimes to Node 24.22.1. Example: A runner caches Node 24.22.0 when a workflow starts.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 3 items remain Keep this PR open: the focused security update remains necessary on main, and no actionable code defect was found. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub Actions selects Node before package installation, validation, publishing, and deployment; the selected runtime also executes authenticated Cloudflare requests. flowchart LR
Workflows[GitHub workflows] --> Setup[Node setup action]
Setup --> Runtime[Node 24.22.1]
Runtime --> Validation[Install and validation]
Runtime --> Domains[Domain request helper]
Domains --> TLS[TLS peer verification]
TLS --> Cloudflare[Cloudflare API]
Technical reviewBest possible solution: Retain the six exact runtime pins and verify the authenticated Node request boundary before landing. Do we have a high-confidence way to reproduce the issue? Main's broad Node selectors and the setup action's cache matching establish how an older runtime can be selected; compromised-peer acceptance was not executed during this review. Is this the best way to solve the issue? Selecting the upstream patched runtime is the smallest complete workflow repair and preserves the existing Node major and pnpm contracts. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 31759069fa96. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: none. SecurityNeeds attention: No concrete introduced vulnerability was found, but the changed TLS authorization boundary needs final-effect evidence. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 6:31 PM ET / 22:31 UTC. |
What Problem This Solves
Existing workflows can select an older Node 24 patch with compromised CA trust.
User Impact
CI and product-router build/deploy jobs select released Node 24.22.1. Existing deployments require the normal owner rollout.
Why This Change Was Made
Pin all six managed workflow runtimes to the qualified patch while preserving the current Node 24 and pnpm 11 contracts.
Evidence
Isolated Linux arm 64
pnpm check,pnpm test(223 passes) andpnpm test:nativepass, including Go race tests and vet. Native macOS tests explicitly skip on Linux. Changed YAML, diff checks and independent P 0–P 2 full-workflow review pass. Main-push production Worker deployment is existing behavior; no deployment was performed during preparation. Future merges require separate permission.