Repository navigation
fix(ci): batch main CodeQL scans on weekly schedule - #160
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR removes main-push CodeQL scans and separates concurrency groups for PR, scheduled, and manual scans. Example: A PR merges into main on Tuesday, November 3, 2026.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it makes a focused, maintainer-approved CI cadence change that main does not yet contain, with no concrete correctness defect found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub events select the CodeQL workflow, which analyzes Actions, TypeScript, Go, and Swift and uploads code-scanning results. flowchart LR
A[Pull request events] --> D[CodeQL workflow]
B[Weekly main schedule] --> D
C[Manual dispatch] --> D
D --> E[Four language analyses]
E --> F[Code scanning results]
Technical reviewBest possible solution: Land the focused workflow change once the existing checks complete successfully. Do we have a high-confidence way to reproduce the issue? Current main explicitly triggers CodeQL for both PRs and main pushes; source inspection establishes the repeated analysis without executing a workflow. Is this the best way to solve the issue? Removing the push trigger and using event-specific concurrency groups addresses the stated scheduling goal within the existing workflow owner. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8ba22e9dddab. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 3, 2026, 7:52 AM ET / 12:52 UTC. |
What Problem This Solves
Main pushes start duplicate native CodeQL scans alongside normal PR analysis.
User Impact
Main is scanned on the existing Monday 04:49 UTC schedule; PR scans remain immediate, manual scans are independent, and active scheduled scans can finish. No application behavior changes.
Why This Change Was Made
Batch the expensive main analysis without changing any language coverage, full Go/Swift build, permissions, action pins, ordinary CI, deployment, or release gate.
.ci-policy.mdrecords the cadence, and the existing workflow contract test enforces it.Evidence
Before commit,
pnpm check,pnpm test(223 passed), andpnpm test:native(race tests across all five Go packages plus vet) passed on isolated Linux with pinned Node/pnpm/lockfile. Pinned oxfmt 0.71.0 produced the final test bytes, copied back byte-identically. macOS tests were not run in that Linux proof. Scoped actionlint, whitespace checks, independent review, and autoreview passed. Exact-head Worker CI and all four CodeQL analyses passed, including completed result uploads. Scheduled/manual isolation is supported by the workflow contract and GitHub concurrency semantics; the hosted run verifies PR execution.