Skip to content

fix(ci): batch main CodeQL scans on weekly schedule - #160

Merged
vincentkoc merged 1 commit into
mainfrom
fix/codeql-weekly-policy-20261103
Nov 3, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/codeql-weekly-policy-20261103

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

Main pushes start duplicate native CodeQL scans alongside normal PR analysis.

User Impact

Main is scanned on the existing Monday 04:49 UTC schedule; PR scans remain immediate, manual scans are independent, and active scheduled scans can finish. No application behavior changes.

Why This Change Was Made

Batch the expensive main analysis without changing any language coverage, full Go/Swift build, permissions, action pins, ordinary CI, deployment, or release gate. .ci-policy.md records the cadence, and the existing workflow contract test enforces it.

Evidence

Before commit, pnpm check, pnpm test (223 passed), and pnpm test:native (race tests across all five Go packages plus vet) passed on isolated Linux with pinned Node/pnpm/lockfile. Pinned oxfmt 0.71.0 produced the final test bytes, copied back byte-identically. macOS tests were not run in that Linux proof. Scoped actionlint, whitespace checks, independent review, and autoreview passed. Exact-head Worker CI and all four CodeQL analyses passed, including completed result uploads. Scheduled/manual isolation is supported by the workflow contract and GitHub concurrency semantics; the hosted run verifies PR execution.

@clawsweeper

clawsweeper Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vincentkoc
vincentkoc marked this pull request as ready for review November 3, 2026 12:35
@vincentkoc
vincentkoc requested a review from a team as a code owner November 3, 2026 12:35
@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Nov 3, 2026
@clawsweeper

clawsweeper Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR removes main-push CodeQL scans and separates concurrency groups for PR, scheduled, and manual scans.

Example: A PR merges into main on Tuesday, November 3, 2026.

  • Before: The merge starts another four-language CodeQL scan after PR analysis.
  • After: Main waits for the Monday 04:49 UTC scan unless a maintainer starts a manual run.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is focused and source-consistent; supplied validation covers contracts and PR analysis rather than the complete scheduling behavior.
Proof confidence 🦐 gold shrimp (3/6) Maintainer-authored PR outside the ordinary proof gate; hosted PR analysis supports retained PR coverage, while the body reports Linux gates and explicitly excludes macOS tests.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Maintainers spend native analysis capacity repeating CodeQL scans after PRs merge.
Reason: The maintainer-authored change explicitly accepts weekly main scanning while preserving PR coverage and manual access.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it makes a focused, maintainer-approved CI cadence change that main does not yet contain, with no concrete correctness defect found.

Priority: P3
Reviewed head: 360851894de4cea224e82d91094c93b335d9762d

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: Supplied evidence does not exercise overlapping manual runs or scheduled/manual isolation; the ordinary contributor proof gate does not apply to this maintainer-authored PR.
Agent review details

How this fits together

GitHub events select the CodeQL workflow, which analyzes Actions, TypeScript, Go, and Swift and uploads code-scanning results.

flowchart LR
  A[Pull request events] --> D[CodeQL workflow]
  B[Weekly main schedule] --> D
  C[Manual dispatch] --> D
  D --> E[Four language analyses]
  E --> F[Code scanning results]
Loading

Technical review

Best possible solution:

Land the focused workflow change once the existing checks complete successfully.

Do we have a high-confidence way to reproduce the issue?

Current main explicitly triggers CodeQL for both PRs and main pushes; source inspection establishes the repeated analysis without executing a workflow.

Is this the best way to solve the issue?

Removing the push trigger and using event-specific concurrency groups addresses the stated scheduling goal within the existing workflow owner.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 8ba22e9dddab.

Provenance checked

  • CodeQL triggers and concurrency changes intended behavior with a stated reason (ec33952: fix(ci): add multi-language CodeQL analysis #118 established consistent four-language scanning across PR, main-push, scheduled, and manual events.)
  • Workflow contract test keeps the original intent (ec33952: The original test intentionally caught trigger and extraction drift; this PR updates that existing contract for the approved cadence.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

What I checked:

  • Verified introduced change: The pinned diff removes only the main-push trigger and changes concurrency ownership; language coverage, builds, permissions, and action pins remain intact. (.github/workflows/codeql.yml:3, 360851894de4)
  • Owner direction and accepted cadence: GitHub confirms MEMBER authorship; the full PR body explicitly chooses weekly main analysis while retaining immediate PR scans and independent manual runs. (.ci-policy.md:1, 360851894de4)
  • Original workflow intent: fix(ci): add multi-language CodeQL analysis #118 introduced PR, main-push, weekly, and manual scans with a narrow workflow contract test; this PR explains its intentional cadence override. (.github/workflows/codeql.yml:7, ec33952bac50)
  • Current-head hosted checks: Worker, Actions, TypeScript, and Go checks succeeded at the reviewed head; Swift analysis remained in progress, with no failed check observed. (.github/workflows/codeql.yml:78, 360851894de4)
  • Repository policy and ownership: Read the complete root policy; no nested policies, maintainer notes, or pr-simplify skill were present for the changed paths. CODEOWNERS routes workflow review to openclaw-secops. Local gates were not executed under the read-only review constraint. (AGENTS.md:3, 360851894de4)
  • Feature ownership history: Workflow history identifies Vincent Koc's original implementation and Peter Steinberger's subsequent tooling and runner maintenance. A follow-history read encountered an unavailable historical blob; commit metadata, the introduction blob, and current-main blame independently establish this trail. (.github/workflows/codeql.yml:1, 8ba22e9dddab)

Likely related people:

  • Vincent Koc: Raw commit ec33952 adds .github/workflows/codeql.yml:14 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: ec33952bac50; files: .github/workflows/codeql.yml)

Labels

Label changes:

  • add P3: This is a bounded CI resource and scheduling improvement with no application behavior change.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a bounded CI resource and scheduling improvement with no application behavior change.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 3, 2026, 7:52 AM ET / 12:52 UTC.

@vincentkoc
vincentkoc merged commit 49683e8 into main Nov 3, 2026
17 checks passed
@vincentkoc
vincentkoc deleted the fix/codeql-weekly-policy-20261103 branch November 3, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant