Repository navigation
Open
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExempts this issue from stale automation.Exempts this issue from stale automation.
Description
Problem
gog calendar update --all-day can fail with Google API error (400 invalid): Invalid start time when it converts an existing timed event to an all-day event.
The update patch sends start.date and end.date, but it does not clear the existing dateTime and timeZone fields. Google applies the nested patch to the existing event, so each boundary can contain both timed and all-day fields.
Reproduction
Start with a normal, non-recurring timed event. Then run:
gog calendar update primary EVENT_ID \
--from 2030-01-01 \
--to 2030-01-02 \
--all-dayThe current dry-run request contains:
{
"start": {"date": "2030-01-01"},
"end": {"date": "2030-01-02"}
}A live update of a normal timed event returned 400 Invalid start time. No recurring-event scope was involved.
Expected behavior
The patch clears dateTime and timeZone when it sets date. A timed update should clear a prior date field for the inverse conversion.
Reacted by clawsweeper
Metadata
Metadata
Assignees
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExempts this issue from stale automation.Exempts this issue from stale automation.
Type
Fields
Priority
None yet
Activity
clawsweeper commentedon Nov 21, 2026
Codex review: this still needs some work.
Summary
This issue identifies a current serialization defect: calendar updates omit incompatible date fields instead of clearing them, and no fixing PR was found.
Reproducibility: Current-main construction and the pinned serializer establish that incompatible fields are omitted from PATCH requests; the reporter supplies the resulting live 400, but no command or test was run here.
Next step
Fix update boundary serialization after establishing failing regressions for timed-to-all-day and inverse conversions, including preservation through recurrence normalization.
Review details
Best possible solution:
Emit explicit incompatible-field nulls in update patches and preserve them through recurrence normalization.
Do we have a high-confidence way to reproduce the issue?
Current-main construction and the pinned serializer establish that incompatible fields are omitted from PATCH requests; the reporter supplies the resulting live 400, but no command or test was run here.
Is this the best way to solve the issue?
Update-specific NullFields handling is a narrow repair that preserves partial-update semantics without replacing whole events or changing shared create behavior.
AGENTS.md: found and applied where relevant.
Remaining risk / open question:
Codex review notes: model internal, reasoning medium; reviewed against 31c4e14186e8.
Label changes
Label changes:
P2: A bounded calendar conversion operation fails while unrelated event operations remain available.impact:ux-friction: An accepted update command returns an opaque invalid-start-time error instead of converting the event.issue-rating: 🦞 diamond lobster: Current issue advisory state selects this label.clawsweeper:source-repro: Current issue advisory state selects this label.clawsweeper:queueable-fix: Current issue advisory state selects this label.clawsweeper:fix-shape-clear: Current issue advisory state selects this label.Label justifications:
P2: A bounded calendar conversion operation fails while unrelated event operations remain available.impact:ux-friction: An accepted update command returns an opaque invalid-start-time error instead of converting the event.Evidence reviewed
Acceptance criteria:
What I checked:
internal/cmd/calendar_update_patch_plan.go:145, 31c4e14186e8)internal/cmd/calendar_build.go:18, 31c4e14186e8)calendar/v3/calendar-gen.go:1806, 35ecdc151456)internal/cmd/calendar_update_patch_plan.go:264, 31c4e14186e8)internal/cmd/calendar_update_patch_plan.go:158, 77c904ee3b9c)How this review workflow works
@clawsweeper re-reviewcomments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.@clawsweeper re-reviewor@clawsweeper re-runon an open PR or issue to request a fresh review only.@clawsweeper reviewto request a fresh review only.@clawsweeper explainto ask for more context, or@clawsweeper stopto stop active automation.Reviewed November 21, 2026, 6:40 PM ET / 23:40 UTC.