Skip to content

build(deps): refresh Google clients and tracking-worker tooling - #1274

Merged
steipete merged 2 commits into
mainfrom
build/round18-deps
Oct 27, 2026
Merged

steipete merged 2 commits into
mainfrom
build/round18-deps

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Refresh the supported Go dependency graph: MCP 1.4.0, x/net 0.62.0, Google API 0.309.0, gRPC 1.85.0, and matching genproto revisions. Update the tracking worker to Cloudflare types 5.20261026.1 and Wrangler 4.153.0 with its lockfile.

Keep the documented Go 1.26 minimum, Go 1.27.3 build toolchain, 24-hour pnpm release cooldown, and existing workerd/security overrides. No runtime or release version changes.

Validation: dependency and lockfile review is clean. Full remote Go checks and vulnerability scanning passed; worker lint/type/tests are tracked in the proof comment. The normal PR workflow covers the worker dry build, Linux, minimum Go, macOS, Windows, and container build.

@steipete
steipete requested a review from a team as a code owner October 27, 2026 19:57
@clawsweeper

clawsweeper Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T19:57:59.380837Z 11b7d28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete
steipete merged commit 82e7fd6 into main Oct 27, 2026
11 checks passed
@steipete
steipete deleted the build/round18-deps branch October 27, 2026 20:14
@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 27, 2026
@clawsweeper

clawsweeper Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR updates Google, MCP, networking, and tracking-worker dependencies with matching lockfiles and an Unreleased changelog entry.

Example: Building gog and the tracking worker from this PR

  • Before: Main selects MCP 1.3.0, Google API 0.308.0, and Wrangler 4.152.0.
  • After: The PR selects MCP 1.4.0, Google API 0.309.0, and Wrangler 4.153.0.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is focused and supported by passing current-head checks; supplied runtime evidence does not exercise the updated Google or MCP client paths.
Proof confidence 🦐 gold shrimp (3/6) This collaborator-authored maintenance PR is outside the ordinary contributor proof gate; current-head CI covers compilation, tests, worker tooling, and dry build, while the linked CLI probe covers only the separate Linux keyring scenario.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: The CLI and worker otherwise remain on older upstream client and tooling releases.
Reason: The maintainer-authored refresh follows established dependency ownership and retains supported baselines and security constraints.

Merge readiness

✅ Ready for maintainer review

Keep this maintainer-authored dependency refresh open: the updates are absent from main, all checks pass on the reviewed head, and inspection found no actionable defect.

Priority: P3
Reviewed head: a54942765b86c620c124f5b6a0f30c10d2234efe

Before merge

None.

Findings

None.

Agent review details

How this fits together

Go dependencies support the CLI's Google API requests, MCP stdio server, and HTML processing; worker dependencies provide Cloudflare types, local development, and deployment tooling.

flowchart LR
  A[CLI commands] --> B[Go client dependencies]
  B --> C[Google APIs]
  D[MCP client] --> E[gog stdio server]
  E --> A
  F[Worker source] --> G[Wrangler tooling]
  G --> H[Cloudflare Worker]
Loading

Technical review

Best possible solution:

Land the focused dependency refresh while preserving the existing toolchain, supply-chain constraints, and worker security pins.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance without a claimed application bug; the review inspected source and supplied validation without running target code.

Is this the best way to solve the issue?

Updating the existing manifests and native lockfiles is appropriately scoped, and no replacement layer or application refactor is needed.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 8c5c062ad9f8.

Provenance checked

  • Google, MCP, networking, and protocol dependency versions keeps the original intent (build(deps): refresh Google clients and worker tooling #1218: Earlier refreshes intentionally retained Go compatibility while updating clients; later refreshes continued that policy.)
  • Worker tooling and lockfile resolution keeps the original intent (9e97292: Refresh eligible tooling while retaining the package manager and release cooldown.)
  • Worker security runtime pin keeps the original intent (1d0d4d2: Use a local workerd engine that rejects disclosed compromised certificate keys, including with explicit historical trust.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned introduced change: The complete introduced diff changes dependency versions, checksums, worker resolution records, and the Unreleased changelog; application code, workflows, schemas, and configuration defaults are unchanged. (go.mod:14, a54942765b86)
  • Existing constraints preserved: Go 1.26.0, toolchain 1.27.3, pnpm 11.28.5, the 1440-minute release cooldown, disabled Sharp build scripts, and security overrides remain intact, including workerd 1.20261021.1 from fix(security): adopt patched workerd certificate rejection #1264. (internal/tracking/worker/pnpm-workspace.yaml:29, a54942765b86)
  • Current-head validation: All 11 check runs succeed at the reviewed head, including minimum-Go, worker, Linux, Windows, macOS, container, and CodeQL checks. (.github/workflows/ci.yml:57, a54942765b86)
  • Separate keyring report: The maintainer's candidate probe in Linux: gog runs dbus-launch at startup, and DBUS_SESSION_BUS_ADDRESS=disabled: skips the file fallback #1258 confirms the disabled-bus fallback remains functional and identifies eager D-Bus initialization as an existing, separately tracked dependency problem.
  • MCP dependency contract: The selected release requires Go 1.25.5, below gog's floor; its release notes describe request-ID, stdio, schema, and lifecycle fixes. gog consumes its server and MCP packages directly. (go.mod:3, 84ad98e6bb81)
  • Wrangler compatibility inspection: The selected release changes dotenv --secrets-file expansion, but repository deployment code and guidance use secret put rather than that option; the worker also explicitly pins its compatibility date. No affected repository input was found.

Likely related people:

  • Josh Avant: Raw commit 1d0d4d2 adds internal/tracking/worker/pnpm-lock.yaml:8 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 1d0d4d230349; files: internal/tracking/worker/pnpm-lock.yaml)

Labels

Label changes:

  • add P3: Routine dependency maintenance with passing current-head validation and no established urgent user-facing regression.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine dependency maintenance with passing current-head validation and no established urgent user-facing regression.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 27, 2026, 4:13 PM ET / 20:13 UTC.

@steipete

Copy link
Copy Markdown
Collaborator Author

Landed as 82e7fd6.

Validation: make ci and govulncheck ./... passed on the remote Go run; the batch then exposed the VM's old pnpm installation. After provisioning pinned tooling in a temporary prefix, worker lint, typecheck, and all 15 tests passed. No reachable vulnerabilities were found; the module-only OpenPGP advisory is not imported. Independent review is clean through P2.

Final-head CI passed Linux, minimum Go, macOS, Windows, and the worker dry build. Docker and CodeQL passed too. The release dry run on merged main passed using the documented current version 0.47.1; it did not publish or tag a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant