Skip to content

feat(auth): use personal Tailscale identity in Companion - #1989

Open
TheAngryPit wants to merge 9 commits into
openclaw:mainfrom
TheAngryPit:feat/personal-tailscale-operator-20261103
Open

TheAngryPit wants to merge 9 commits into
openclaw:mainfrom
TheAngryPit:feat/personal-tailscale-operator-20261103

Conversation

@TheAngryPit

@TheAngryPit TheAngryPit commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Related: #1117. Depends on openclaw/openclaw#163765 for the personal-identity Control UI contract. Separate from the managed Gateway upgrade in #1128.

What Problem This Solves

Companion users need an explicit way to use their verified Tailscale identity instead of shared Gateway credentials.

User Impact

Users can select personal Tailscale identity for a supported secure Tailscale Serve Gateway. Personal sign-in verifies a non-shared profile and never falls back to Shared owner after a failure. Existing shared-credential connections and Windows node identity remain available through their existing owners.

The saved-row Open dashboard action also respects Personal mode. It requires that the requested Gateway is currently admitted; an inactive or unverified Personal row refuses the launch and asks the user to reconnect. It does not silently switch the selected Gateway or use a retained shared token.

Why This Change Was Made

The operator connection verifies the person before exposing Chat and Dashboard. Native Dashboard proofs stay bound to the selected Gateway, verified person, device, recovery scope and connection generation. Reconnection, profile changes and selection changes retire the previous authority. The branch is reconciled with canonical Windows main while retaining current request cancellation, search, keepalive and setup dispatch checks.

This PR covers the Serve route. LocalPrimary personal identity is not included: it needs a separate public Core producer for signed bind/use and a corresponding Windows follow-up. This PR does not configure a Gateway or automatically migrate existing profiles.

Evidence

Main reconciliation — 12 November 2026

Published head 70eb8a8f7b3fe4489637b09144f5fe14e78859ea is an ordinary merge of c43d070bea087ef940d40571855e41715b0d3aac and public main 0bd934818151c39890aa13d3ebed5e5dc4f7f9fb, with tree 838e8807c49903859b28837fd4cb5badcf24a9d3. The six resource append conflicts retain both the personal-identity guidance and main's tool-details panel strings. XML parsing, uniqueness and independent parent-value comparisons passed across all six locales; main's intentional removal of an obsolete compatibility label is retained.

The exact staged merge tree was built and tested before creating the merge commit: official build and native UI assembly compilation passed; Tray 6,371 passed; localization 41 passed; personal manager/policy 23 passed. Shared had 5,847 passed, 30 skipped and the same 12 missing-privilege failures, with no additional failed names. The conflict-resolution P0–P3 review completed 17/17 passes without findings; independent TestAudit and named NoComments accepted this resolution scope.

The new canonical CI run is in progress; it is not claimed green. This resource reconciliation includes no new live-Gateway/native UI interaction run. The earlier runtime proofs and remaining person/app-role, public Core dependency and release-qualification limits below retain their stated commits and boundaries.

Earlier implementation and runtime evidence

Follow-up 500a5752773a2a8e20a58a08810613ea57870c8a (tree bd852533143b6f2b7f26d9ad82141666a2015c0d) fixes the private WebView2 profile-close lifecycle exposed by the preceding head's native CI. Closing now awaits Profile.Deleted, rather than accepting a dispatcher drain as equivalent acknowledgement. The original native test independently observes that event and requires it before CloseAsync returns, retaining its existing ten-second bound. This acknowledges profile closure, not physical directory deletion.

Canonical Build/Test on 500a executed the original private-profile test successfully (2.319s) and the stale/current native-bridge reply test successfully (8.752s); the complete native Tray UI suite passed 1,344 cases with nine not executed. The tested merge contained the exact repaired source blobs. This demonstrates the profile-close acknowledgement repair on native CI, not physical directory deletion. The overall run still failed two Mock Gateway cases: UsageHero could not locate its target beyond the ten-row preview; UsagePinned failed an earlier ChatComposerInput lookup. Neither is described as a product-layout repair.

Earlier head c43d070bea087ef940d40571855e41715b0d3aac carries that UsageHero setup correction and failure-only diagnostics for the unresolved UsagePinned lookup. It also routes personal verification and revalidation failures through typed, localized native guidance, preserving the attempted failure kind across rollback and distinguishing incomplete recovery. Six locales are included. This changes presentation without granting authority or adding credential fallback.

On production tree 2187ef19ba421bfbaa3e951d1258adcd37671cbb (commit 9596629bf683678ebd156dbec90d7a055374b588), the official product build and native UI test assembly compilation passed; Tray passed 6,329 with zero skips, and Shared passed 5,843 with 30 skipped and the same 12 host symlink-privilege failures. Real manager/rollback/presentation regressions have RED/GREEN evidence (23 manager/policy cases and six rollback/presentation cases pass). Independent P0–P3 review completed all 31 passes with no findings; TestAudit accepted the separate producer, rollback and presentation contracts. Named NoComments accepted the final source including its required new-module documentation. Final tree adeb18cde65d4ca1d73e81d4a8d2cd34ae7d3ff6 differs only by six helper documentation lines; that delta received a separate scoped-clean P0–P3 review and successful documentation/prerequisite checks. No product suite was rerun or claimed for the comment-only delta. Earlier-head canonical CI 43213859705 failed three tests: Automations_ScopesToAgentsAndCoversMainStates(Dark), SessionsDesignNativeWindowGallery, and NativePagesAndOwnerLinks_StayInOneWorkspaceWindow(Dark). These remain unresolved current-head failures; no inherited/flaky classification is asserted. Rendered localization qualification remains incomplete. Compilation and static review are not presented as native UI proof.

Commit 36b8090527fbe9bbfd08ec96747ef35c96e5017a integrates published 32e59cbef166a3b2e5b8ecd8b0d889f19be5c424 with pinned canonical Windows main 3f47e83888db83740660d03c3ecd403550235187, the saved-row repair and bounded error-reply diagnostics. Its tested tree is 5bd0937fca4266fcf4424c1dfb32d782f467b1a5, with 62 changed paths relative to that canonical base. No private runtime composition or unrelated personal patches are included.

The shared-token regression exercises the real replacement connect over the Gateway fixture, after an empty request ledger is observed under the transition semaphore. It checks the actual rejected replacement request and preservation of the durable device token. The initial mock lifecycle does not send a wire connect.

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs or instructions
  • Tests or validation
  • Security hardening
  • Chore or infrastructure

Scope

  • Tray or WinUI UX
  • Windows node capability
  • Local MCP or winnode
  • Gateway, connection, or pairing
  • Setup or onboarding
  • Permissions, privacy, or security
  • Tests, CI, or docs

Required proof pools

  • windows-winui-interactive: native connection selection and personal Dashboard behavior.
  • windows-wsl-gateway-e2e: pairing, recovery and real Gateway identity behavior.

Validation

The final required build/Shared/Tray closeout ran on tree 5bd0937fca4266fcf4424c1dfb32d782f467b1a5; earlier owner-specific evidence is identified separately.

  • ./build.ps1 -Project All -Configuration Debug -NoTrustRepository: all projects passed, including WinUI, on Windows x64. An earlier attempt stopped at prerequisite detection because this harness omitted the native OS/architecture environment. After verifying the actual Windows x64 host and installed Visual Studio VC runtime, normal builds used process-local native OS/architecture values. No dependency or machine policy was changed.
  • dotnet test tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore: 5,843 passed, 30 skipped, 12 failed, total 5,885. All 12 failures are missing host CreateSymbolicLink privilege in three test owners identical to pinned canonical main; exact failure-set comparison matches the preceding repaired-tree run. No permission override, new skip or weakened assertion was used. The 133 affected personal/media/WebSocket/search/startup cases passed with zero skips in the initial integration; those owner sources are unchanged.
  • dotnet test tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore: 6,323 passed, zero failed/skipped.
  • Earlier tree 604c: dotnet build tests/OpenClaw.Tray.UITests/OpenClaw.Tray.UITests.csproj -p:Platform=x64 -r win-x64 passed, zero warnings/errors. Compilation only; native UI tests were not executed. The final delta changes only error-reply diagnostics and comments in the product window.
  • Unchanged-owner evidence from the initial integration: dotnet test tests/OpenClaw.Connection.Tests/OpenClaw.Connection.Tests.csproj --filter 'FullyQualifiedName~GatewayConnectionManagerPersonalIdentityTests|FullyQualifiedName~GatewayPersonalAuthenticationPolicyTests|FullyQualifiedName~CredentialResolverTests|FullyQualifiedName~ConnectWithSharedTokenAsync_RevalidatesDurableTokensUnderTransitionSemaphore': 56 passed, zero failed/skipped, 553ms. The UI-only repair does not change these owner or fixture sources.
  • Full independent P0-P3 source review completed 23 passes and identified the saved-row Personal-mode bypass. The repair binds the requested Gateway through admission and retry; its static architecture guard failed against the original owners and passed after the fix. The focused AppRefactor and actual central launcher suites passed 145 cases with zero skips. This is static wiring and launcher-owner evidence, not an executed native row/retirement journey. A separate resource-schema finding was verified identical to canonical main and remains explicitly dispositioned as an unchanged baseline issue.
  • Focused independent P0-P3 review of the complete ten-file repair and actual launcher/window/lease context: four passes, exit zero, scoped-clean, no actionable, filtered or rejected findings. This supplements the original full review and its explicit finding dispositions.
  • The final one-file diagnostics delta received another independent P0-P3 source review: complete, exit zero, scoped-clean, no findings. Error replies stay best effort; warnings contain fixed text, exception type and numeric HRESULT, without exception messages, signing inputs or reply content.
  • TestAudit accepts the source-shape guard as static evidence with a mounted-proof retirement condition. Native named NoComments completed; two unproven comments were removed and the silent error handler received bounded diagnostics. Independent rubber-duck implementation/proof-plan review found no further actionable defect in the selected paths, conditional on that now-reviewed repair. These are source/proof-plan reviews, not native acceptance.

Real Behavior Proof

  • Environment tested: actual Windows x64 Companion in a task-owned profile against the existing real Windows/WSL managed Tailscale Serve Gateway. No daily service/configuration change or shared credential fallback.
  • PR head tested: c43d070bea087ef940d40571855e41715b0d3aac; Companion executable SHA256 A52ACB508281C3067EC2000F390F35081E9B1D5BF7E2C10B6BBD20F04E248F78.
  • Gateway provenance: existing custom daily Core 0f6610ca2777edb870fa5fee1d04a3884bcceb4a, version 2026.11.3, entry SHA256 d602c263712830450271ccba9552a9c6d5ddf55eec8091ea03f4f7ad0fe73e24. This demonstrates that runtime composition, not a verbatim shipping release of the unmerged public dependency.
  • Actual native Chat: synthetic turn reached its terminal reply; independent stored sender matched the verified native users.self profile.
  • Actual embedded Dashboard: production WebView validated Tailscale hello/recovery scope, matched the same device/person, accepted the synthetic conversation's protected sessions.messages.subscribe result, and rendered its marker.
  • Actual after-signing device denial: positive production-manager/bridge control admitted and changed the synthetic label. A fresh genuine nonce/signature was held while the exact task paired grant was removed through native CLI. Held connect returned NOT_PAIRED / PAIRING_REQUIRED within 3.813 seconds (native validity window 120 seconds). No protected mutation was sent; independent task-label readback was unchanged. This negative test uses the real manager/bridge and Gateway, not an automated embedded-WebView revocation journey.
  • Stored-data compatibility: official portable v2026.11.1 production writer to current c43d production reader passed 1 test, zero skipped, preserving actual synthetic gateway records, identity hashes and preferences. This is data compatibility, not installer replacement.
  • Cleanup: task clients closed and task paired/pending grants absent; primary identities, existing services, configuration and Serve routes preserved.
  • Screenshot or artifact links verified? Marker-only native WebView capture was inspected locally; receipts/capture are not claimed as public downloadable artifacts.
  • Not verified or blocked: genuinely unapproved personal identity/app-role denial (unapproved/revoked device denial is distinct); rendered localization and remaining native UI journeys; signed installer replacement; unmerged public Core #163765 compatibility/release agreement. LocalPrimary remains outside this PR.

Earlier-head canonical CI 43213859705 failed three tests: Automations_ScopesToAgentsAndCoversMainStates(Dark), SessionsDesignNativeWindowGallery, and NativePagesAndOwnerLinks_StayInOneWorkspaceWindow(Dark). These remain unresolved current-head failures; no inherited/flaky classification is asserted.

Ready for Review denotes GitHub review state, not merge readiness or completed end-to-end qualification.

Security Impact

  • New permissions or capabilities? No new operator permission; adds an opt-in personal authentication mode.
  • Secrets or tokens handling changed? Yes. Personal mode excludes shared-token fallback and binds native proofs to the current verified lease.
  • New or changed network calls? Yes. Existing authenticated profile/recovery and personal media/native bridge routes.
  • Command or tool execution surface changed? No.
  • Data access scope changed? No broader grant. The Gateway remains the authority for pairing, identity and scopes.
  • If any answer is Yes, explain the risk and mitigation: fail closed on profile, route or generation changes; preserve shared mode and separate node identity. Saved-row personal launches check the requested Gateway before window effects. Native lifecycle repair has the labelled CI evidence above; current-head personal Chat/Dashboard and device revocation have actual-runtime evidence. Unapproved-person/app-role denial and the remaining native journeys remain open.

Compatibility and Migration

  • Backward compatible? Shared mode is preserved. Personal mode requires compatible Core support; unsupported personal admission fails closed.
  • Config or environment changes? Opt-in saved Gateway authentication mode; no automatic server configuration.
  • Migration needed? No automatic data migration. This PR does not perform feat: upgrade legacy managed Gateways to Tailscale auth #1128's managed Gateway upgrade.
  • If yes, list the exact upgrade steps: not applicable here; portable stored-data compatibility is verified above. Signed installer replacement and full recovery qualification remain outstanding.

Review Conversations

  • I replied to or resolved every bot review conversation addressed by this PR.

  • I left unresolved only conversations that still need maintainer judgment.

  • Review conversations and hosted checks must be assessed on the final pushed head; no CI dispatch is presented as a completed build or review.

Latest-main refresh — 21 November 2026

This branch now merges Windows main 794f530aa933de07b1b2bd618c0ac6e9d3d74a4b and preserves this PR's opt-in personal Tailscale operator mode. Conflict resolution retained current main window-visibility and UI-wait contracts, the PR's Dashboard admission path, lease fencing and file-media content-type handling, and both main's resource updates and the six localized personal-auth resource sets.

The hello-ok rejection path now raises typed PersonalIdentityUnverified before the legacy authentication notification when the Gateway returns the wrong auth method or a missing/blank recovery scope. The existing protocol fixture now asserts that typed failure for those inputs. The challenge parser's public contract is documented.

Focused current-source checks passed:

  • PersonalTailscaleGatewayClientTests: 9 passed.
  • GatewayConnectionManagerPersonalIdentityTests: 10 passed.
  • ConnectionPagePersonalIdentityTests and GatewayDirectConnectServiceTests: 68 passed.
  • Full UI test project compiled for win-x64. The opted-in UsagePinned_ToggleOwnsHitPointAndTabOrderWithVisibleOperationFeedback UI smoke did not pass: it timed out waiting for the Light theme selector while the fixture app reported responsive. This is not a personal-auth journey and is not claimed green.
  • Current PR diff Autoreview P0–P3: scoped-clean, nine Codex passes, no actionable findings. This is source review, not runtime qualification.

No live personal sign-in replay was performed in this refresh. Existing recorded runtime evidence above retains its original revision and environment boundaries. Hosted CI for this head is pending.

Verify the canonical personal profile on the current Gateway connection before enabling operator features. Keep native Dashboard proof bound to that lease, retire private browser profiles on close, and retain existing credential authentication.
@clawsweeper

clawsweeper Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:feature Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed clawsweeper:intake:feature Preliminary submission classification; full source review pending. labels Nov 3, 2026
@clawsweeper

clawsweeper Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge.

What this changes

Adds per-Gateway personal Tailscale authentication for Companion chat and an embedded Dashboard.

Example: Connect to wss://node.example.ts.net using Personal Tailscale identity.

  • Before: Companion resolves saved operator credentials.
  • After: Companion sends no shared credential and verifies the Gateway's personal profile before enabling operator features.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Useful implementation with meaningful native and protocol coverage, a retained recovery defect, limited inspectable runtime evidence and unresolved product direction.
Proof confidence 🦐 gold shrimp (3/6) Real behavior proof is necessary before merge. See Before merge.
Patch quality 🦐 gold shrimp (3/6) 2 actionable review findings remain.

Product

Kind: Feature · Worth it: Needs a maintainer decision · Fix scope: Complete
User problem: Users cannot explicitly use their verified personal Tailscale identity for Companion chat and Dashboard instead of shared Gateway credentials.
Reason: The Serve-route capability has clear value and preserves existing credential mode, but its new saved authentication choice needs an owner decision.

Merge readiness

⛔ Blocked before merge - 3 items remain

Keep this PR open: personal authentication remains absent from main, and the contribution is distinct; the existing recovery finding remains unresolved.

Priority: P2
Reviewed head: 70eb8a8f7b3fe4489637b09144f5fe14e78859ea
Owner decision: Required. See Decision needed.

Decision needed

  • Question: Should Companion expose a saved, explicit Personal Tailscale operator mode alongside Gateway credentials?
  • Recommendation: Accept the explicit personal mode: Approve the distinct operator choice while preserving shared mode and separate Windows node identity.
  • Why: This adds an authentication setting and changes operator identity semantics; no approval of this specific direction appears in this PR's discussion, and the related managed-upgrade approval covers different behavior.

Before merge

  • Add real behavior proof - The author reports actual Windows Chat attribution, embedded Dashboard admission and after-signing device denial with precise Companion and custom Gateway provenance; those authentication owners are unchanged by reconciliation, but the underlying captures remain private and the changed selector/recovery presentation has no inspectable visible evidence. After adding proof, update the PR body, then request a new review with @clawsweeper re-review. The PR author or someone with repository write access can request it.
  • Route rejected personal hello metadata through localized recovery (P2) - When Personal mode receives hello-ok with the wrong auth method or a missing recoveryScope, this branch emits an English string containing “authentication”. HandleAuthenticationFailedAsync classifies it as generic Auth, while GatewayPersonalErrorPresentation handles only the typed personal failures. The editor, notification and status window therefore expose raw English text, and Connection recovery offers generic credential repair. Publish a typed personal failure and render actionable native guidance for this compatibility rejection. The previously reported defect remains at the reviewed head.
  • Resolve merge risk - The release owner must identify a supported public Core and Control UI version before shipping Personal mode; the tested custom composition does not establish an available compatible installation.

Findings

  • [P2] Route rejected personal hello metadata through localized recovery — src/OpenClaw.Shared/OpenClawGatewayClient.cs:2875-2878
  • [P3] Document the new public authentication module contracts — src/OpenClaw.Tray.WinUI/Helpers/PersonalGatewayAuthChallenge.cs:7-15

Tests

  • Low-value test tests/OpenClaw.Tray.Tests/ConnectionPagePersonalIdentityTests.cs: Remove the literal French-prose equality assertion, which duplicates resource text and makes editorial changes fail; retain the error-kind mapping and raw-diagnostic exclusion assertions.
  • Missing end-to-end proof: Provide inspectable runtime output for the reported personal Chat/Dashboard behavior and visible selector/recovery evidence, redacting private endpoints, IPs and credentials.
Agent review details

How this fits together

The connection manager turns saved Gateway settings into authenticated operator connections and supplies verified identity to native chat and the Dashboard signing bridge.

flowchart LR
  A[Saved Gateway settings] --> B[Credential resolver]
  B --> C[Connection manager]
  C --> D[Verified operator identity]
  D --> E[Native chat]
  D --> F[Dashboard signing bridge]
  F --> G[Gateway Dashboard]
Loading

Technical review

Best possible solution:

Keep the existing connection and Dashboard owners, complete typed personal recovery, and ship the opt-in mode against an agreed public producer contract.

Do we have a high-confidence way to reproduce the issue?

Source establishes both the missing main capability and the rejected-hello recovery defect; the existing protocol test supplies wrong-method and empty-scope inputs, but no target code was executed in this review.

Is this the best way to solve the issue?

The registry, credential resolver, connection manager and Dashboard launcher are appropriate existing owners; the smallest repair routes rejected personal hello metadata through the typed native recovery path already added.

Full review comments:

  • [P2] Route rejected personal hello metadata through localized recovery — src/OpenClaw.Shared/OpenClawGatewayClient.cs:2875-2878
    When Personal mode receives hello-ok with the wrong auth method or a missing recoveryScope, this branch emits an English string containing “authentication”. HandleAuthenticationFailedAsync classifies it as generic Auth, while GatewayPersonalErrorPresentation handles only the typed personal failures. The editor, notification and status window therefore expose raw English text, and Connection recovery offers generic credential repair. Publish a typed personal failure and render actionable native guidance for this compatibility rejection. The previously reported defect remains at the reviewed head.
    Confidence: 0.99
  • [P3] Document the new public authentication module contracts — src/OpenClaw.Tray.WinUI/Helpers/PersonalGatewayAuthChallenge.cs:7-15
    The new challenge/parser module lacks the file-purpose comment, usage example and public-contract documentation required by root AGENTS.md. Add those here and to the other new public authentication modules that lack them. This remains non-blocking advice. Its late discovery was acknowledged in the preceding review; comparison with the first-reviewed head confirms this module is unchanged.
    Confidence: 0.98
    Late finding: first raised on code an earlier review cycle already covered.

Overall correctness: patch is incorrect
Overall confidence: 0.94

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 0bd934818151.

Merge-risk options

Maintainer options:

  1. Establish supported producer compatibility (recommended)
    The release owner identifies the public Core and Control UI version supporting this native personal-authentication contract.
  2. Defer feature inclusion
    Keep this PR open until the upstream contract has an agreed release path.

Provenance checked

  • Operator readiness keeps the original intent (64d505b: Require hello-ok on the current connection before application RPCs; personal mode extends that boundary with profile verification.)
  • Credential precedence and recovery changes intended behavior with a stated reason (fix: harden gateway recovery credential handoffs #1076: Preserve paired credentials and authorize credential handoffs; the PR explicitly bypasses operator credentials only for selected Personal mode and retains node resolution.)
  • Interactive client identity keeps the original intent (7f6706f: Use gateway-client/ui for Companion's interactive identity and presence; personal connections retain that identity.)
  • Dashboard launch ownership keeps the original intent (4db2960: Route retired native management surfaces through the Gateway Dashboard; this change extends the existing launcher and preserves requested-Gateway admission.)
  • Assistant media authority keeps the original intent (a76c852: Resolve media through authenticated, connection-scoped Gateway contracts; personal media retains the selected connection and verified-person boundary.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Barbara Kudiess: Raw commit 7f6706f adds src/OpenClaw.Connection/GatewayClientFactory.cs:34 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 7f6706ff30ca; files: src/OpenClaw.Connection/GatewayClientFactory.cs)
  • Ranjesh Jaganathan: Raw commit 8afcaf9 adds src/OpenClaw.Tray.WinUI/Services/Connection/GatewayClientFactory.cs:13 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 8afcaf9847f0; files: src/OpenClaw.Tray.WinUI/Services/Connection/GatewayClientFactory.cs)
  • Sebastien Tardif: Raw commit 51ee815 adds src/OpenClaw.Connection/GatewayClientFactory.cs:30 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 51ee81596c47; files: src/OpenClaw.Connection/GatewayClientFactory.cs)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

No label changes.

Label justifications:

  • P2: This is an optional authentication capability with a bounded recovery defect and no demonstrated urgent regression.
  • merge-risk: 🚨 compatibility: Personal Dashboard authentication depends on an unmerged public Control UI contract, while acceptance used a custom Gateway composition.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (2 earlier review cycles)
  • reviewed 2026-11-03T15:17:58.246Z sha 1cc74a4 :: needs real behavior proof before merge. :: [P2] Localize personal-authentication errors at the WinUI boundary
  • reviewed 2026-11-12T16:18:38.405Z sha 70eb8a8 :: needs real behavior proof before merge. :: [P2] Route rejected personal hello metadata through localized recovery | [P3] Document the new public authentication module contracts

Reviewed November 12, 2026, 11:26 AM ET / 16:26 UTC (Revision 3).

@roboclaw-bot

Copy link
Copy Markdown
Contributor

PR cleanup review

Reviewed head: e35c7a1b859a291bad4f8708a294c981d5ff7bb1. Main comparison: e59374c064f43d68f5c72d070d4c89ef2d20ec3b.

Personal authentication is still absent from main, so this is not a superseded change. The updated head improves same-person and media fencing, but the core Control UI dependency remains open and live end-to-end authority proof is explicitly incomplete. The English rejection/revocation strings still reach the WinUI error display directly. Keep this draft for localization, compatible-release agreement, current-main reconciliation and independent security/runtime qualification.

Action in this cleanup pass: leaving this PR open. No branch changes or runtime-proof waiver. The findings above come from source, discussion and recorded-CI review; Windows validation was not rerun in this pass.

@TheAngryPit
TheAngryPit marked this pull request as ready for review November 12, 2026 00:14
@TheAngryPit

Copy link
Copy Markdown
Contributor Author

Note

🤖 Codex responding on behalf of TheAngryPit

Actual Windows acceptance now covers personal Chat, embedded Dashboard admission, device revocation after signing, and stored-data compatibility at c43d070bea087ef940d40571855e41715b0d3aac. This does not complete merge qualification.

Workflow Observed result
Native Companion Chat A synthetic conversation reached its terminal reply through the existing provider. Its stored sender matched the verified native users.self personal profile.
Embedded Dashboard The actual production WebView used the same device/person, validated Tailscale hello and recovery scope, received a protected sessions.messages.subscribe result for the synthetic conversation, and rendered its terminal marker.
After-signing device revocation A positive control using the production connection manager and native bridge transformation admitted and changed only the synthetic label. A fresh real challenge/signature was then held in memory while the exact task paired grant was removed through native CLI. Releasing that signed connect returned NOT_PAIRED / PAIRING_REQUIRED; no protected write was sent, and independent label readback was unchanged. The result completed within 3.813 seconds of signing, within the native 120-second validity window.
Stored-data upgrade Official portable v2026.11.1 wrote an isolated synthetic profile; current c43d reopened it, preserving gateway records, identity hashes and preferences: 1 passed, 0 skipped. This proves portable data compatibility, not installer replacement.

Runtime provenance: existing custom Windows/WSL daily Core 0f6610ca2777edb870fa5fee1d04a3884bcceb4a, version 2026.11.3; Gateway entry SHA256 d602c263712830450271ccba9552a9c6d5ddf55eec8091ea03f4f7ad0fe73e24. Companion executable SHA256 A52ACB508281C3067EC2000F390F35081E9B1D5BF7E2C10B6BBD20F04E248F78. This is actual compatible-runtime evidence, not proof that the unmerged public Core dependency is shipping verbatim. Task clients were closed and task paired/pending grants removed; existing services, configuration and primary identities were preserved.

Remaining limits: initial unapproved-device admission also returned PAIRING_REQUIRED, but a genuinely unapproved person/app-role denial remains unproven. The held-signature test exercises the production manager/bridge and real Gateway; it is not an automated revocation journey inside the embedded WebView. Public Core #163765 compatibility/release agreement remains outstanding. Local receipts are not claimed as downloadable public artifacts.

Current-head canonical CI 43213859705 failed three tests: Automations_ScopesToAgentsAndCoversMainStates(Dark), SessionsDesignNativeWindowGallery, and NativePagesAndOwnerLinks_StayInOneWorkspaceWindow(Dark). These are unresolved current-head failures, not classified as inherited or flaky.

@TheAngryPit

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. labels Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants